Morello copy_page cherry-pick#22
Open
heshamelmatary wants to merge 2 commits into
Open
Conversation
Regular writes zero the capability tags in memory, which is exactly what we want in clear_page(), but in copy_page() we want to preserve the tags of the source page. We can achieve this by using capability loads/stores to copy both data and tags. Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
We have just done away with runtime detection for Morello in early initialisation paths. As a result, standard runtime detection based on the Morello CPU capability (ARM64_MORELLO) is now pointless (and misleading). Remove all uses of the ARM64_MORELLO capability. In assembly, this allows us to simplify quite a few paths. In C, the CPU capability is only used through the system_supports_morello() function. We preserve that function for convenience, making it rely purely on the CONFIG macro. Where it is used inside a code region that is already #ifdef'd on the macro, it becomes a no-op and we remove it. The Morello CPU feature itself is preserved, as well as runtime detection for it (based on the Morello and TTPBHA ID fields). This is not essential, but makes it easy to keep HWCAP2_MORELLO exposed to userspace, and reading the ID fields is marginally useful in case Morello hardware somehow did not set them to the right value. Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
Collaborator
Author
|
Can probably squash both commits of @kevin-brodsky-arm would prefer that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.