Conversation
Collaborator
Author
|
This latest commit adds a dask requirement, so if this is merged, our instances will have to get rebuilt to include dask. Dask speeds up the runoff addition step significantly by chunking our xarray dataset when it is opened, which allows for chunked addition of columns. This is super important for large-scale data processing. Speed comparison (for CONUS-wide processing, 3 hours) |
…s parity with other datastreams
This reverts commit 58125b7.
JordanLaserGit
approved these changes
Jan 29, 2026
Collaborator
JordanLaserGit
left a comment
There was a problem hiding this comment.
@quinnylee Thanks for this work!! Special thanks for adding the unit tests and example. Easy PR to approve.
harshavemula-ua
approved these changes
Jan 29, 2026
Collaborator
Author
|
Merging this closes issue #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #28 . This change extracts
q_lateralfrom the NWM's channel routing data, remaps it onto the nextgen hydrofabric (user must provide mapping, see https://alabama.box.com/s/kpcy8jg772bqpusouzt7wx1gfjn00spb for the latest NHD to NextGen HF 2.2 mapping), and outputs it for the purpose of t-route ingestion.Additions
q_lateralfrom channel routing data and maps NHD values onto the NextGen hydrofabric (becauseq_lateralis additive, we just add all the values from the NHD that correspond a NextGen nexus togetherdocs/examplesTesting
Checklist
Testing checklist
Target Environment support