Skip to content

Stabilize Linux CI by gating real-adapter placeholder test on dist artifacts - #10

Merged
CL-BAF merged 2 commits into
mainfrom
copilot/fix-linux-github-actions-job
Sep 21, 2026
Merged

CL-BAF merged 2 commits into
mainfrom
copilot/fix-linux-github-actions-job

Conversation

Copilot AI commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

The Linux workflow failed in test:unit because one integration-manager test executed a real claude-code install/detect path that depends on dist/* artifacts, while the unit pipeline only builds dist-test/*. This change aligns that test with existing dist-gated real-adapter tests to prevent false negatives in CI.

  • Root cause isolation

    • The failing case was PLACEHOLDER_ISSUE is the exact string both claude-code and codex adapters emit, which asserted successful install without checking build artifact availability.
  • Targeted test hardening

    • Updated the test to use the existing distReady() gate and skip when production build artifacts are absent.
    • Kept scope surgical: test-only change, no production/runtime logic changes.
  • Behavioral impact

    • Unit runs no longer fail due to missing dist bundles in environments that intentionally run only build:test.
    • Real-adapter verification remains intact when npm run build artifacts are present.
test("PLACEHOLDER_ISSUE is the exact string both claude-code and codex adapters emit", async (t) => {
  if (!distReady()) {
    t.skip("dist missing — run npm run build")
    return
  }
  // existing real-adapter assertions...
})

Co-authored-by: CL-BAF <224583307+CL-BAF@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'linux' Stabilize Linux CI by gating real-adapter placeholder test on dist artifacts Sep 21, 2026
Copilot AI requested a review from CL-BAF September 21, 2026 00:25
@CL-BAF
CL-BAF marked this pull request as ready for review September 21, 2026 00:52
@CL-BAF
CL-BAF merged commit 156d609 into main Sep 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants