Repository navigation
fix: propagate non-contention lock acquisition errors - #11
Merged
Merged
Conversation
Owner
|
Looks good. Thanks for fixing the lock error handling and adding regression coverage for both stores. |
Contributor
Author
|
You're welcome! Thanks for reviewing and merging the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only EEXIST now enters lock contention handling in StateStore and OrchestratorStore. EACCES, EROFS and EMFILE propagate immediately with their original error instead of becoming a five-second lock timeout. Orchestrator lock metadata writing also runs under cleanup after successful acquisition.
Closes #5.
Validation: typecheck and build pass; unit suite 345 passed / 1 skipped; both contract tests pass. Eight regression cases cover immediate original errors and EEXIST retry across both stores. Touched files pass Prettier. Repository-wide format checking reports 89 existing unrelated files; they are unchanged.
AI assistance: implemented and tested with OpenAI Codex. Live provider integration was not exercised.