Repository navigation
fix: preserve state when atomic replacement fails - #12
Merged
Merged
Conversation
Owner
|
Looks good. Thanks for fixing this and adding regression coverage for both stores. |
Contributor
Author
|
You're welcome! Thanks for reviewing and merging the state persistence fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the last valid state file when replacement fails. Both stores now use a shared flushed temporary-file writer with at most three rename attempts (50ms and 100ms backoff), best-effort temporary cleanup, and a clear persistence error retaining the original cause. The unsafe direct-write fallback is removed.
Closes #4.
Six regression cases cover both stores: first rename fails then succeeds; repeated rename failure preserves the exact previous bytes; and a partial temporary write fails without changing the destination or leaving temporary files. The repeated-failure tests failed before this fix. Persistence documentation is updated.
Validation: typecheck/build pass; 343 unit tests pass, 1 skipped; both contract tests pass. Touched TypeScript files pass Prettier. Repository-wide format checking still reports 89 unchanged files. The AGENTS graphify update command could not run because graphify is not installed (no graph file is present). Live provider integration was not exercised.
AI assistance: implemented and tested with OpenAI Codex.