fix(exports): expose ./package.json in the exports map - #16
Closed
cldmv-bot[bot] wants to merge 4 commits into
Closed
fix(exports): expose ./package.json in the exports map#16cldmv-bot[bot] wants to merge 4 commits into
cldmv-bot[bot] wants to merge 4 commits into
Conversation
… invalid -C= form The devcheck scanner (merged via #10) had two nits: the space-form branch (`--conditions x` / `-C x`) consumed tokens[i+1] as the value but did not advance the loop index, so a value that itself looks like a flag could be double-processed; and it handled `-C=value`, which Node rejects outright ("bad option") so it can never appear. Advance i past the consumed value token, drop the dead `-C=` branch (valid forms: `--conditions=x`, `--conditions x`, `-C x`), and add -C short-flag test coverage. Redo of the change that was mistakenly pushed onto the already-merged fix/devcheck-condition-detection branch (which opened a diverged PR #12); this branch is cut fresh from next so the diff is only the scanner delta.
… invalid -C= form (#13)
Node's exports map is a strict allowlist: with only "." and "./main"
declared, `require.resolve("@cldmv/uuid/package.json")` (and any tool that
locates a package by resolving its package.json) throws
ERR_PACKAGE_PATH_NOT_EXPORTED. This broke @cldmv/rummage's web build.
Add the conventional `"./package.json": "./package.json"` entry so the
manifest is resolvable by name, and a regression test that asserts both the
exports entry and real Node self-resolution.
Fixes #6
cldmv-bot
Bot
added
! fix → next
Contributor
|
Closing — this branch was cut from a stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What's Changed
💥 Breaking Changes
No breaking changes
✨ Features
No new features
🐛 Bug Fixes
📦 Dependencies
No dependency updates
🔧 Other Changes
No other changes
👥 Contributors