[Option Appraisal Module] [Package 1: Measures] Split 0: Move old measures to _legacy module

[spjuhel]

This PRs preps the field for the reworks of the Measure / MeasureSet classes.

Because the design completely changes, tests and code using the legacy code will fail.

To avoid that while gradually pushing the new code and before the new option appraisal module is fully ready, this PR moves the old code from measures to _legacy_measures module, and import from there.

PR Author Checklist

• Read the Contribution Guide
• Correct target branch selected (if unsure, select develop)
• Descriptive pull request title added
• Source branch up-to-date with target branch
• Documentation updated
• Tests updated
• Tests passing
• No new linter issues
• Changelog updated

PR Reviewer Checklist

• Read the Contribution Guide
• CLIMADA Reviewer Checklist passed
• Tests passing
• No new linter issues

[chahank]

Excellent! Quick question for completness: would this lead to/allow us supporting the use of the current cost_benefit module as a legacy module for users for some time?

[spjuhel]

Yes, that's exactly the idea!

This PR makes it so that everything that requires Measure and MeasureSet before the refactor go and fetch them from _legacy_measure (which contains the code before the refactor), including CostBenefit.

Once we don't want these any more, we can remove them and the _legacy_measure folder.

The code that requires the new objects will import from the original measure folder, containing the new code.

[spjuhel]

What do you think about the tutorials for the old Measure/MeasureSet classes (also worth discussing CostBenefit)?

More specifically:

• Should I take care of this in this PR? [Option Appraisal Module] [Package 1: Measures] Split 0: Move old measures to _legacy module #1274 OR in the PR that will also include the tutorial(s) for the new classes? (i.e. final split of the Measure changes package)
• Currently, the tutorials are in the "Impact" submenu; the new ones will be in their own submenu. Where should I keep the old ones?

[spjuhel]

I went ahead.

• Added an Attention note in soon to be legacy tutorials (which we can adapt in the future)
• Created a pre-structure for the future documentation

This PR is open for review!

[peanutfun]

Looks good to me! Only one thing: Please add a link to the new "Adaptation appraisal guides" menu to the Attention block in the old tutorial.

Would it make sense to add a deprecation warning to the old Measures class or would that be too confusing?