Skip to content

May Revisions to the Application#1

Open
mnfurey25 wants to merge 4 commits into
mainfrom
may_revisions
Open

May Revisions to the Application#1
mnfurey25 wants to merge 4 commits into
mainfrom
may_revisions

Conversation

@mnfurey25
Copy link
Copy Markdown
Collaborator

  • Specifying parcel number as the default for the OPA number
  • Implementing variables, such as signature and contact preferences in the application and the PDFs

@travissouthard travissouthard self-assigned this Apr 30, 2026
Copy link
Copy Markdown
Member

@travissouthard travissouthard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael!

Coming to this WAY too late, but I added some notes about some of the questions below.
I am happy to help debug those false True checks. But these changes are great! Thank you!

Comment on lines 405 to 408
default: |
Because the City’s assessed value should be 100% of the market value, I request that my property’s assessment be changed to $600.

I believe that the Office of Property Assessment erred in characterizing my property. I do not have central air.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of this default. This might confuse someone filling it out

Comment on lines 375 to 383
fields:
- Did you find one or more comparable recent sales?: market_analysis
input type: radio
required: true
choices:
- Yes
- No
---
mandatory: market_analysis == 'Yes'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mandatory check keeps consistently evaluating as True even when I choose No in the previous question. I'm not sure what is causing this issue.

Comment on lines 250 to 253
continue button field: continuing
mandatory: if_appraisal == 'Yes'
question: |
You had an appraisal.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is also always evaluating as True even when I choose no on the "Did you have an appraisal" question

@travissouthard
Copy link
Copy Markdown
Member

Hi @mnfurey25,
I tidied up some of the python code to both make it a little more "Pythonic" but also so that variables and functions have clearer names. I think one of the changes I made to what is now called get_home_guesses that we can go back to having one address input. I set a threshold of 6 characters so that results will be reasonable when they come back. I couldn't figure out how you got the original flow with entering letters and the list updating as you did that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants