Refactoring function Complexity from 22-15 and 16-15, src/install.js#70
Open
mrahmed2026 wants to merge 4 commits into
Open
Refactoring function Complexity from 22-15 and 16-15, src/install.js#70mrahmed2026 wants to merge 4 commits into
mrahmed2026 wants to merge 4 commits into
Conversation
mrahmed2026
changed the title
|
mrahmed2026
changed the title
Author
|
I have fixed the elint errors and sonar cloud issues on this file and refactored the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #3
Refactored 2 different functions from their complexities (22 and 16) to a complexity of at least 15.
I broke the code down and put many of the conditional statements into different helper functions.
This in turn helped to reduce the complexity of the function, as instead of doing the complex conditional logic, it simply had to make a function call.
Hence reducing the overall complexity.
The file path is src/install.js