Refactor duplicate code in src/messaging/data.js#92
Open
jdufitum wants to merge 11 commits into
Open
Conversation
Consolidated identical code blocks in the conditional structure of src/messaging/data.js to improve maintainability. The repeated assignment of message.newSet = true was refactored into a single condition to reduce redundancy and enhance code clarity.
…e. I also added the original contents of the file widgets.js
…omments from line 81 to 90
…84 to line 91 of the file data.js in the src/messaging
…duplicate code block from line 84 to line 91 of the file data.js in the src/messaging
…added comments and tested the new code chunck
- Adjusted indentation levels to match the expected number of tabs. - Ensured consistent formatting for better readability and maintainability. Affected lines: - Line 84: Increased indentation from 3 tabs to 4 tabs. - Line 89: Increased indentation from 4 tabs to 5 tabs. - Line 92: Increased indentation from 5 tabs to 6 tabs. - Line 93: Increased indentation from 4 tabs to 5 tabs. - Line 94: Increased indentation from 3 tabs to 4 tabs. - Line 95: Increased indentation from 3 tabs to 4 tabs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue CMU-17313Q/NodeBB#8
Resolves CMU-17313Q/NodeBB#8
This pull request refactors the code in src/messaging/data.js by removing duplicate code blocks between lines 83 and 89. The code has been optimized to improve maintainability and prevent redundancy. Additionally, adjustments were made to ensure functionality remains consistent after the refactor.
This pull request resolves issue #8 .