Skip to content

Fix ESLint/type errors in fib.ts and fibRoute.ts #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alreemt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ESLint/type errors in fib.ts and fibRoute.ts #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/fibRoute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
// Endpoint for querying the fibonacci numbers
// src/fibRoute.ts
import type { Request, Response } from "express";
import fibonacci from "./fib"; // use default import, since fib.ts exports default

Check failure on line 3 in src/fibRoute.ts

View workflow job for this annotation

GitHub Actions / test 

File '/home/runner/work/github-recitation-ts/github-recitation-ts/src/fib.ts' is not a module.

const fibonacci = require("./fib");
export const fibRoute = (req: Request, res: Response): void => {
const numStr = req.params.num; // string
const n = Number(numStr); // number

export default (req, res) => {
const { num } = req.params;
if (isNaN(n)) {
res.status(400).send(`Invalid number: ${numStr}`);
return;
}

const fibN = fibonacci(parseInt(num));
let result = `fibonacci(${num}) is ${fibN}`;
const fibN = fibonacci(n);
let result = `fibonacci(${n}) is ${fibN}`;

if (fibN < 0) {
result = `fibonacci(${num}) is undefined`;
result = `fibonacci(${n}) is undefined`;
}

res.send(result);
Expand Down
Loading