Skip to content

changed color of text and buttons to black#121

Open
huiningliang wants to merge 4 commits into
CMU-313:masterfrom
huiningliang:colorchange
Open

changed color of text and buttons to black#121
huiningliang wants to merge 4 commits into
CMU-313:masterfrom
huiningliang:colorchange

Conversation

@huiningliang
Copy link
Copy Markdown
Collaborator

Because the background is a very light shade, changing the buttons to a dark color such as black should make it more obvious to users.

@huiningliang huiningliang added this to the HW1 milestone Sep 9, 2021
@huiningliang
Copy link
Copy Markdown
Collaborator Author

Resolved #82
Accessibility score has increased from 77 to 79; Colors of the instruction text as well as the cancel button are now changed to black, which is considerably more visible than the original light gray(?). The lighthouse score did improve, but not significantly, which is understandable given the size and difficulty of resolving this issue. The phrase "style = "color: black"" was added behind the lines related to the two recommended error locations, which changed the text color to black in both places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant