Removing Duplicate IDs on "Current user details" page - Allen Ding#149
Open
ADing4818 wants to merge 1 commit into
Open
Removing Duplicate IDs on "Current user details" page - Allen Ding#149ADing4818 wants to merge 1 commit into
ADing4818 wants to merge 1 commit into
Conversation
…file. Originally, all of the menu item IDs were the same (i.e. all were headingOne)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Lighthouse was run on the "Current user details" page, the "Accessibility" score was 83. One of the red flags was that there were duplicate IDs in the HTML file (i.e. "headingOne" was seen throughout the file). Once I saw that the menu items (elements that had the IDs of "headingOne") were generated in a for loop, I used a template variable (forloop.counter), to stick onto "heading", so that each generated menu item would have an ID of "heading1", "heading2", etc.
After doing so and running Lighthouse again, the "Accessibility" score went up to 90 (menu_main.html).
resolve #147