ci(lint): shellcheck shipped scripts + typos - #19
Merged
Merged
Conversation
Extends foundry's self-lint beyond actionlint: shellcheck on the bash foundry ships (foundry-init.sh, setup-labels.sh) that consumers run at onboarding, and typos for doc/identifier slips. Self-exercising — this workflow runs on its own PR. actionlint's embedded shellcheck stays off for now (a later tightening, to avoid red-walling every run: block at once).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends foundry's self-lint (
lint-workflows.yml, already running actionlint) with two deterministic hygiene jobs:foundry-init.sh,setup-labels.sh(the scripts consumers run at onboarding). shellcheck is preinstalled on ubuntu runners.Self-exercising: this workflow runs on its own PR, so its first run is the exercise. actionlint's embedded shellcheck stays off (
-shellcheck=) for now — enabling it across everyrun:block at once is a separate tightening. Free on public runners.