Conversation
Group the 9 reusable workflows under a _ prefix (GitHub forbids subdirs in .github/workflows/, so a filename prefix is the only grouping GitHub allows) and give tier0 a functional name: _guards.yml (secret scan + ruleset-guard). Triggers stay unprefixed (lint-workflows, release-please, commitlint). Updated foundry-init's generated callers + CI mapping + the guards job name, the header usage examples, and README/OVERVIEW/FEATURES/DESIGN. Also corrected the stale no_var-job doc mention (folded into lint by the earlier change). BREAKING CHANGE: reusable-workflow paths changed. uses: .../java.yml@vX etc. must become .../_java.yml, and tier0.yml -> _guards.yml. @v1 keeps the old paths (that alias stays frozen); update the uses: path when moving to @v2.
Owner
Author
|
Superseded — folding the workflow _-prefix + tier0→_guards into the unified restructure PR on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure, step 2 (the workflow rename; the presets split was #22). Groups the 9 reusable workflows under a
_prefix and renamestier0.yml→_guards.yml(functional name for secret-scan + ruleset-guard).Why the prefix: GitHub forbids subdirectories in
.github/workflows/— every file sits at the top level — so a filename prefix is the only way to group the reusable library and separate it from the real triggers (lint-workflows,release-please,commitlint, which stay unprefixed).Updated:
foundry-initgenerated callers +$CImapping + the generatedguards:job name; each workflow's header usage example; README (table + prefix-convention note), OVERVIEW, FEATURES, DESIGN. Corrected the staleno_var-job doc mention (folded intolint). No CHANGELOG hand-edit — release-please owns it.!→ release-please will propose v2.0.0): reusable-workflow paths changed. Consumers pinned to@v1keep the old paths (that alias stays frozen at the last v1.x); update theuses:path when adopting@v2. jobbuddy inlines its CI, so it's unaffected.Not in this PR: the
ruleset-guardcomposite action (guard-logic dedup for jobbuddy) — that's a follow-on with its own cross-repo ref handling. This PR is purely the structural rename.