Repository navigation
feat(jev): centralize the advisory layer toggles in each mise [env] block - #58
Merged
Merged
Conversation
…lock Give the Jev layer's non-secret knobs (JEV_PROVIDER, JEV_MODEL, TYPESAFE_AI_BASE_URL, JEV_REVIEW_MIN_FILES, plus the downstream JEV_TOOLCALL_TRIAGE / JEV_FEATURE_PRECHECK hook toggles) one commented, opt-in home in all six mise templates instead of scattered exports. Every line stays commented, so absent == off == today; the key itself is never committed. Does not name the scripts dir, so boundary.test.mjs stays green. Documents the mise [env] reach limit (only mise run/exec or an activated shell) in the template and scripts/jev/README.md.
CMaintz
force-pushed
the
feat/jev-mise-env-block
branch
from
October 4, 2026 15:29
92b12a4 to
5404f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gives the advisory Jev layer's non-secret knobs one commented, opt-in home in the
[env]block of every mise template (ts/java/php/dotnet/kotlin/python), instead of leaving them as scattered shell exports.The group covers
JEV_PROVIDER,JEV_MODEL,TYPESAFE_AI_BASE_URL,JEV_REVIEW_MIN_FILES, and the downstream hook togglesJEV_TOOLCALL_TRIAGE/JEV_FEATURE_PRECHECK. Every line stays commented, so absent == off == today's behavior.JEV_API_KEYis deliberately not here: the key stays in the shell, never in committed config.Why it is safe for the gate
The block never names the scripts directory, so
boundary.test.mjs(which fails the build if any mise file or gate workflow references that path) stays green. Jev remains strictly advisory and out of the six-verb oracle.Reach caveat (documented)
A mise
[env]value only reaches processes started viamise run/mise execor a mise-activated shell, so a Claude Code hook sees these only when the editor was launched from such a shell. This is spelled out in the template comment and inscripts/jev/README.md.Verification
boundary.test.mjsgreen; noscripts/jevsubstring in anymise/*.toml.mise env/mise execemit the uncommented vars (aftermise trust) and propagate them to child processes.docs/FEATURES.md"jev/" entry andscripts/jev/README.mdConfig section.