Repository navigation
fix(backend): make company research notes per user - #169
Merged
Merged
Conversation
Notes lived on the shared companies row, so every user read and overwrote the same text, and it also grounded everyone else's cover letters. They now live in user_company_notes keyed by (user_id, company_id).
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Company research notes were stored on the shared
companiesrow, so every user read and overwrote the same notes. Worse,CompanyGroundingServicefed those notes into cover-letter prompts, so my notes could end up grounding someone else's letter.Stacked on #160 because the Testcontainers base only exists there so far.
user_company_notes, keyed by(user_id, company_id), and drops the two columns fromcompanies.CompanyResearchRepositoryPort+ adapter. The use case, controller and grounding service all take the current user's id now.CompanyServiceTestand a newCompanyGroundingServiceTest, Postgres tests for the adapter, and a migration test that runs V035, seeds old-style notes, then applies V036 and checks where each one ended up.PostgresIntegrationTestnow shares one container across the run. With one container per class, the second class with the same Spring config got the cached context pointing at a stopped database. The new migration test hit that.The API and frontend are unchanged. 571 backend tests pass locally with Docker.