feat(explorer): WASD keyboard navigation; 3D lines show through dimmed terms - #68
Merged
Merged
Conversation
…-depth # Conflicts: # app/src/components/GraphLegend.tsx
3 tasks
…-depth # Conflicts: # app/src/lib/explorer-2d.ts # design/AUTONOMOUS_DECISIONS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner requests: 3D links vanishing behind dimmed terms, and WASD keyboard navigation in 2D and 3D. Decision note: A97 (A96 is taken by open PR #64).
3D: lines behind receded terms
All spheres are transparent (
nodeOpacity0.95), so three.js sorted each one against the single merged web by distance. A receded (dimmed) sphere that happened to draw first wrote depth and erased every line behind it. Only comets and glow showed through.The fix is a fixed
renderOrder: glow, then solid spheres (these still write depth and occlude), then lines (the web plus the focused link objects), then receded spheres (depthWrite=falsebelowEXPLORER.three.solidOpacity), then comets. The sphere materials belong to 3d-force-graph and it swaps them on its own schedule, so ascene.onBeforeRenderpass applies the order every frame.Verified with headless screenshots: with a term selected and the camera zoomed in on receded spheres, the lines now pass through them. Before the fix they stopped at the sphere's edge.
Keyboard navigation (
explorer-keys.ts+ tests)tabindex=0,role="application", and an aria-label with a "use W A S D" hint. The open legend ends with a one-line key hint for the current view (EN + DA).Checks
mise run fix && mise run gate: exit 0.The 3D hover drop is within run-to-run noise.
Do not merge without the owner.