fix(explorer): responsive bar, wider legend, 3D domain names, smooth type toggles, no stranded terms - #70
Merged
Conversation
…red edge toggles (WIP)
…isible helpers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner feedback (2560x1440) on the Explorer, plus the "no stranded nodes" fix. Decision note A93b (amends A93a).
1. Responsive control bar. The bar measures the space it has (a ResizeObserver on its slot, then a before-paint check of its in-flow width, so an open popover or result list never shrinks it). It steps down from full (domain pills with names, the Find a term field open, "Relationships") to medium (dot chips), then compact (the old "Links" plus a search icon), then the Controls sheet. It never wraps to a second row, and it never overlapped the legend or the "i" at any size tested. Measured sizes: 2560 and 1440 full, 1280 with the legend closed full and with it open medium, 1100 medium, below ~900 the sheet.
2. Bar follows the theme. It already used tokens (bg/surface/border/fg), and so do the popovers. This was verified in light and dark screenshots.
3. Cream void. This was a stale cache (owner confirmed). Checked in 2D and 3D in light theme, on first load and when switching live.
4. Legend sizing. Collapsed, it is at least 10rem wide from 1440px up. Open, it is
clamp(18rem, 22vw, 28rem). The bar's left inset follows it (--xp-legend[-open]).5. 3D domain names. A large, faint name sprite sits above each galaxy in the domain's colour. It is hidden with its domain, dims when a term is selected, hovered or on a route, and follows the theme. It never takes a click.
6. Toggle hitching. In 2D, edge classes are worked out in plain data and only the edges that change are touched. More than 120 changes are applied a batch per frame; a smaller change fades in. In 3D, a type or "show all" toggle skips re-evaluating 3d-force-graph's accessors, and the web appears a batch per frame. Reduced motion makes it all instant.
B. No stranded terms.
backboneOf(..., visible)is computed over the shown terms in both 2D and 3D. With AI off, Data poisoning keeps its strongest visible edge. There is a unit test for this.Longest frame at 2x CPU throttle, 1440x900 (two runs):
Screenshots at 2560x1440, 1440x900 and 1280x800, in light and dark, 2D/3D/legend open, plus a live theme switch, are in the agent scratchpad under
perf/ux/after,perf/ux/checkandperf/ux/before.mise run fix && mise run gateexits 0. Merged with origin/main (#66, #67). Not merging: the owner merges.