release(v0.2.0): gate DMG behind appdmg + add license (fix macOS/Linux release legs) - #4
Merged
Merged
Conversation
…ix macOS/Linux legs)
The v0.2.0 release built Windows fully (Setup.exe/nupkg/RELEASES) but failed on:
- Linux rpm: "License field must be present" → add "license": "Apache-2.0" to
package.json (the project's actual license; also correct metadata).
- macOS DMG: "Cannot find module 'appdmg'" — appdmg's darwin-only native addons
(macos-alias/fs-xattr) don't compile on the hosted runner (old native code, no
prebuilds), so npm drops the optional chain; setuptools didn't help. Gate
MakerDMG behind a runtime existsSync('node_modules/appdmg') check: the DMG
builds on local mac dev (appdmg resolves); CI ships the portable mac .zip
instead — which is ALSO what Squirrel.Mac auto-update consumes, so the mac
update path is unaffected. Drop the now-moot setuptools/assert steps.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013nbxSeU5FDHmFY3A1akRgE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the first v0.2.0 tag: Windows built fully, but Linux rpm failed (
License field must be present) and macOS DMG failed (Cannot find module 'appdmg'— native addons don't build on the runner). Addslicense: Apache-2.0; gates MakerDMG behind appdmg availability so CI ships the mac .zip (which is what Squirrel.Mac auto-update uses anyway). After merge I re-cut the v0.2.0 tag.🤖 Generated with Claude Code
https://claude.ai/code/session_013nbxSeU5FDHmFY3A1akRgE