fix data type in test to pass build#186
Open
JasonRuonanWang wants to merge 1 commit intoCODARcode:masterfrom
Open
fix data type in test to pass build#186JasonRuonanWang wants to merge 1 commit intoCODARcode:masterfrom
JasonRuonanWang wants to merge 1 commit intoCODARcode:masterfrom
Conversation
Collaborator
|
@qliu21, please hold off on merging this until we discuss it at a Tuesday meeting. This issue has come up in my rewrite of the Huffman compression code. @JasonRuonanWang, were you getting a build error? Are |
Collaborator
See this error encountered in #189. |
|
Apple clang thinks they're different types. This code outputs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken on Mac with mgard_x serial option enabled.