Fix floating-point exception in Zstd::Decompress#254
Merged
JieyangChen7 merged 1 commit intoCODARcode:masterfrom Feb 5, 2026
Merged
Fix floating-point exception in Zstd::Decompress#254JieyangChen7 merged 1 commit intoCODARcode:masterfrom
JieyangChen7 merged 1 commit intoCODARcode:masterfrom
Conversation
Bug: When decompressing multiple variables sequentially, if the decompressed size (actual_out_count) was larger than the current buffer_size, the Resize() function would free and reallocate BOTH in_data AND out_data. This destroyed the compressed data that was just copied to in_data, causing ZSTD_decompress to read garbage/zeros and produce invalid output. Fix: Only reallocate out_data when needed for larger output, leaving in_data (which contains the compressed data) untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: When decompressing multiple variables sequentially, if the decompressed size (actual_out_count) was larger than the current buffer_size, the Resize() function would free and reallocate BOTH in_data AND out_data. This destroyed the compressed data that was just copied to in_data, causing ZSTD_decompress to read garbage/zeros and produce invalid output.
Fix: Only reallocate out_data when needed for larger output, leaving in_data (which contains the compressed data) untouched.