Migrate UserFront from Java 8 / Spring Boot 1.5.4 to Java 17 / Spring Boot 3.4.5#6
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
… Boot 3.4.5 - Update Spring Boot parent from 1.5.4.RELEASE to 3.4.5 - Update Java version from 1.8 to 17 - Replace mysql-connector-java with mysql-connector-j - Remove redundant spring-boot-starter-jdbc dependency - Remove deprecated MySQL5Dialect (Hibernate 6 auto-detects) - Replace deprecated datasource pool properties with HikariCP properties - Update Maven wrapper to 3.9.9 - Rewrite SecurityConfig for Spring Security 6 (lambda DSL, no WebSecurityConfigurerAdapter) - Replace all javax.servlet imports with jakarta.servlet - Replace all javax.persistence imports with jakarta.persistence - Change GenerationType.AUTO to GenerationType.IDENTITY for MySQL compatibility - Fix findOne() -> findById().orElse(null) for Spring Data 3.x Co-Authored-By: Stephen Cornwell <stephen@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Big-bang migration of the UserFront Spring Boot application from Java 8 / Spring Boot 1.5.4 to Java 17 / Spring Boot 3.4.5.
Changes
Build & Dependencies (
pom.xml)1.5.4.RELEASE→3.4.51.8→17mysql:mysql-connector-java→com.mysql:mysql-connector-jspring-boot-starter-jdbc(transitively included byspring-boot-starter-data-jpa)Configuration (
application.properties)hibernate.dialect = org.hibernate.dialect.MySQL5Dialect(Hibernate 6 auto-detects)Maven Wrapper
Spring Security 6 (
SecurityConfig.java)WebSecurityConfigurerAdapter(deleted in Spring Security 6)@EnableGlobalMethodSecurity→@EnableMethodSecurity@Bean SecurityFilterChainwith lambda DSLantMatchers→requestMatchers,authorizeRequests→authorizeHttpRequestsAuthenticationManagerBuilderconfig (Spring Boot 3.x auto-discoversUserDetailsService+PasswordEncoderbeans)Jakarta EE namespace migration
javax.servlet→jakarta.servletinRequestFilter.javajavax.persistence→jakarta.persistencein 9 domain entity filesHibernate 6 compatibility
GenerationType.AUTO→GenerationType.IDENTITYin all 8 entities (prevents table-based sequence emulation on MySQL)Spring Data 3.x
findOne(id)→findById(id).orElse(null)inAppointmentServiceImpl.javaCompilation verified:
./mvnw clean compilepasses.Review & Testing Checklist for Human
./mvnw clean compilepasses on your environment with Java 17+findByIdcall)Notes
./mvnw testwas not run in CI (no DB available). Manual verification of compilation was done successfully.RequestFilterCORS filter and all controllers/services compiled cleanly with no otherjavax→jakartaissues found.Link to Devin session: https://app.devin.ai/sessions/db958b69c57a4220b7dcac0a91258669
Requested by: @stephencornwell
Devin Review