forked from housseindjirdeh/angular2-hn
-
Notifications
You must be signed in to change notification settings - Fork 9
chore(angular-react): Migrate Footer component to React #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
3
commits into
master
Choose a base branch
from
devin/1778795824-migrate-footer-component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| .footer { | ||
| position: relative; | ||
| padding: 10px; | ||
| height: 60px; | ||
| letter-spacing: 0.7px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .footer a { | ||
| font-weight: bold; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| .footer a:hover { | ||
| text-decoration: underline; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 768px) { | ||
| .footer { | ||
| display: none; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import React from 'react'; | ||
| import styles from './Footer.module.css'; | ||
|
|
||
| export const Footer: React.FC = () => { | ||
| return ( | ||
| <div className={styles.footer}> | ||
| <p> | ||
| Show this project some ❤ on{' '} | ||
| <a | ||
| href="https://github.com/hdjirdeh/angular2-hn" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| GitHub | ||
| </a> | ||
| </p> | ||
| </div> | ||
| ); | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 React component added to an Angular project — will not compile or function
The new
Footer.tsxis a React component (importsReact, usesReact.FC, JSX syntax) added to a project that is entirely Angular 9. The project has no React dependency inpackage.json:13-28, uses Angular CLI (angular.json), and all existing components follow Angular conventions (e.g.,src/app/core/footer/footer.component.ts). This component cannot be compiled by the Angular build toolchain, and even if it could, Angular has no mechanism to render aReact.FCcomponent. The project already has a working Angular footer component atsrc/app/core/footer/footer.component.tsthat is used insrc/app/app.component.html:6as<app-footer>. This new component is entirely non-functional dead code.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an intentional Angular-to-React migration as requested. The React component is the migration target — the Angular source files are deliberately left unchanged per the playbook's "Forbidden Actions" (do not remove Angular components). The component will be functional once React is added to the project's build toolchain.