feat: scaffold React app foundation for Angular-to-React migration#261
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
feat: scaffold React app foundation for Angular-to-React migration#261devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- Scaffold Vite + React + TypeScript project in react-app/ - Install react-router-dom, sass, vite-plugin-pwa - Port TypeScript models: Story, Comment, User, Settings, PollResult - Create API service (hackerNewsApi.ts) with async/await fetch calls - Create formatCommentCount utility function - Add placeholder stub components and pages for parallel development Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…item types - time_ago is a string like '4 hours ago', not a number - FeedType now reflects actual API item types (link, poll, job, ask, comment) instead of feed endpoint names Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up the
react-app/foundation for the Angular-to-React migration. This is the base that other parallel sessions depend on.What's included:
create-vitewithreact-tstemplatereact-router-dom,sass,vite-plugin-pwaStory,Comment,User,Settings,PollResulthackerNewsApi.ts) — replaces RxJS-basedHackerNewsAPIServicewith async/awaitfetchcallsformatCommentCount.ts) — ported from Angular pipeFeedPage,ItemDetailsPage,UserPageHeader,Footer,Settings,FeedItem,Comment,Loader,ErrorMessageReview & Testing Checklist for Human
react-app/builds cleanly:cd react-app && npm install && npm run buildsrc/app/shared/models/hackernews-api.service.tsNotes
Usermodel preserves the originalcrated_timefield name (typo in original Angular model)Link to Devin session: https://app.devin.ai/sessions/7e2d1ecb8e2643c983d28dad42582497
Requested by: @matthewguerra-cog
Devin Review