Upgrade remaining dependencies and set up standalone ESLint#11
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Upgrade remaining dependencies and set up standalone ESLint#11devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Upgrade react-icons to ^5.6.0 - Upgrade react-countdown to ^2.3.6 - Upgrade sass to ^1.99.0 - Upgrade classnames to ^2.5.1 - Install eslint, @eslint/js, eslint-plugin-react, eslint-plugin-react-hooks - Create eslint.config.js with flat config format - Remove eslintConfig from package.json - Add lint script to package.json - Fix unused variable in src/lib/words.js Co-Authored-By: shahmir.masood <shahmir.masood@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session D of the 4-session parallel migration. Upgrades remaining dependencies and sets up standalone ESLint configuration (flat config format) to replace CRA's
eslint-config-react-app.Dependency Upgrades
react-icons:^4.3.1→^5.6.0react-countdown:^2.3.2→^2.3.6(supports React >= 15, compatible with React 19)sass:^1.49.9→^1.99.0classnames:^2.3.1→^2.5.1ESLint Setup
eslint@^9,@eslint/js@^9,eslint-plugin-react@^7,eslint-plugin-react-hooks@^5as dev dependencieseslint.config.jsusing ESLint flat config format with:@eslint/jsrecommended ruleseslint-plugin-reactrecommended rules (withreact-in-jsx-scopeandprop-typesdisabled)eslint-plugin-react-hooksrecommended ruleseslintConfigfield frompackage.json"lint": "eslint src/"script topackage.jsonLint Fixes
_→()insrc/lib/words.js(line 17)Review & Testing Checklist for Human
npx eslint src/passes with no errorsnpm run buildstill works with upgraded depsreact-iconsv5 icons render correctly (imports unchanged, API compatible)Notes
react-countdownlatest (2.3.6) haspeerDependencies: { react: '>= 15' }so it's fully compatible with React 19eslint-plugin-react-hooks@^5.2.0was chosen over v7 to avoid React Compiler rules that aren't applicable yeteslint.config.jsuses ESMimportsyntax; Node emits a warning about missing"type": "module"in package.json but this is harmless and adding it would break CRA's CommonJS expectationsLink to Devin session: https://app.devin.ai/sessions/b0c8fd91fe6847539ab3b779b5a0b23e
Requested by: @shahmir-masood
Devin Review