Skip to content

Make app permanently light mode #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make app permanently light mode #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta name="theme-color" content="#ffffff" />
<meta name="description" content="wordle created using react" />
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
<!--
Expand Down
2 changes: 1 addition & 1 deletion public/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
],
"start_url": ".",
"display": "standalone",
"theme_color": "#000000",
"theme_color": "#ffffff",
"background_color": "#ffffff"
}
16 changes: 4 additions & 12 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function App() {
guesses: [],
solutionIndex: '',
});
const [theme, setTheme] = useLocalStorage('theme', 'dark');

const [highContrast, setHighContrast] = useLocalStorage(
'high-contrast',
false
Expand All @@ -54,7 +54,7 @@ function App() {
const [isStatsModalOpen, setIsStatsModalOpen] = useState(false);
const [isSettingsModalOpen, setIsSettingsModalOpen] = useState(false);
const [isHardMode, setIsHardMode] = useState(hardMode);
const [isDarkMode, setIsDarkMode] = useState(theme === 'dark');

const [isHighContrastMode, setIsHighContrastMode] = useState(highContrast);
const { showAlert } = useAlert();

Expand Down Expand Up @@ -92,18 +92,12 @@ function App() {
}, [guesses]);

useEffect(() => {
if (isDarkMode) document.body.setAttribute('data-theme', 'dark');
else document.body.removeAttribute('data-theme');
document.body.removeAttribute('data-theme');

if (isHighContrastMode)
document.body.setAttribute('data-mode', 'high-contrast');
else document.body.removeAttribute('data-mode');
}, [isDarkMode, isHighContrastMode]);

const handleDarkMode = () => {
setIsDarkMode(!isDarkMode);
setTheme(isDarkMode ? 'light' : 'dark');
};
}, [isHighContrastMode]);

const handleHighContrastMode = () => {
setIsHighContrastMode(!isHighContrastMode);
Expand Down Expand Up @@ -182,10 +176,8 @@ function App() {
isOpen={isSettingsModalOpen}
onClose={() => setIsSettingsModalOpen(false)}
isHardMode={isHardMode}
isDarkMode={isDarkMode}
isHighContrastMode={isHighContrastMode}
setIsHardMode={handleHardMode}
setIsDarkMode={handleDarkMode}
setIsHighContrastMode={handleHighContrastMode}
/>
<StatsModal
Expand Down
11 changes: 0 additions & 11 deletions src/App.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,6 @@
--color-text-secondary: #333;
--color-icon: #333;

[data-theme='dark'] {
--color-background: #191919;
--color-cell: #444444;
--color-key: #4f4f4f;
--color-key-text: #fff;
--color-key-secondary: #fff;
--color-text-primary: #fff;
--color-text-secondary: #adadad;
--color-icon: #fff;
}

[data-mode='high-contrast'] {
--color-present: #06b6d4;
--color-correct: #f97316;
Expand Down
3 changes: 0 additions & 3 deletions src/components/SettingModal/SettingModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ const SettingModal = ({
isOpen,
onClose,
isHardMode,
isDarkMode,
isHighContrastMode,
setIsHardMode,
setIsDarkMode,
setIsHighContrastMode,
}) => {
return (
Expand All @@ -20,7 +18,6 @@ const SettingModal = ({
isOn={isHardMode}
onToggle={setIsHardMode}
/>
<Row title="Dark Mode" isOn={isDarkMode} onToggle={setIsDarkMode} />
<Row
title="High Contrast Mode"
desc="For improved color vision"
Expand Down