fix: add nodeRef to CSSTransition for React 19 compatibility#9
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: add nodeRef to CSSTransition for React 19 compatibility#9devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Upgrade react-transition-group to ^4.4.5 - Add nodeRef to CSSTransition in Alert.jsx - Add transitionRef to CSSTransition in Modal.jsx Co-Authored-By: shahmir.masood <shahmir.masood@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
nodeRefprops to allCSSTransitioncomponents to prepare for React 19 compatibility. In React 19,react-transition-grouprequires explicitnodeRefusage instead of relying onfindDOMNode, which has been removed.Changes:
react-transition-groupfrom^4.4.2to^4.4.5useRef, createnodeRef, pass it toCSSTransitionand attach to the<span>childtransitionRef(distinct from the existing click-outsideref), pass it toCSSTransitionand attach to the<div className={styles.modalContainer}>childReview & Testing Checklist for Human
refforuseOnClickOutsideis preserved separately)Notes
This is Session B of a 4-session parallel migration to React 19. Only
Alert.jsx,Modal.jsx, andpackage.jsonwere modified.Link to Devin session: https://app.devin.ai/sessions/6eaaa16c52e8448194ccaf82d3c0614a
Requested by: @shahmir-masood
Devin Review