fix: resolve top 5 SonarQube issues (weekly sweep)#601
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: resolve top 5 SonarQube issues (weekly sweep)#601devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- S1948: Make 'errors' field transient in InvalidRequestException (CRITICAL/BUG) - S1452: Replace ResponseEntity<?> with concrete type in ArticleApi (CRITICAL) - S1452: Replace ResponseEntity<?> with concrete type in CommentsApi (CRITICAL) - S2885: Fix non-thread-safe static Calendar in DateTimeHandler (MAJOR/BUG) - Spotless formatting fix in DefaultJwtServiceTest Co-Authored-By: Kyu Choi <kyu.choi@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weekly SonarQube code quality sweep resolving the top 5 open issues ranked by severity → type → effort → recency.
Issues Fixed
InvalidRequestException.javatransientto non-serializableErrorsfield in Serializable classArticleApi.java:36ResponseEntity<?>withResponseEntity<Map<String, Object>>ArticleApi.java:45ResponseEntity<?>withResponseEntity<Map<String, Object>>CommentsApi.java:41ResponseEntity<?>withResponseEntity<Map<String, Object>>DateTimeHandler.javaCalendarwith staticTimeZone+ localCalendar.getInstance()callsAdditionally,
spotlessApplyauto-formatted one line inDefaultJwtServiceTest.java(pre-existing formatting issue).Review & Testing Checklist for Human
DateTimeHandlerchange doesn't affect timestamp handling — theCalendar.getInstance(UTC_TIMEZONE)creates identical UTC calendars each call, just thread-safe nowResponseEntity<Map<String, Object>>return types don't break any client-side deserialization expectations./gradlew testlocally to confirm all 68 tests passNotes
choikh0423_demo-spring-boot-test-coveragespotlessCheckand full test suite (68 tests) pass locallyLink to Devin session: https://app.devin.ai/sessions/92cbe447ffeb41708a91f7df1a6b12ec
Requested by: @choikh0423
Devin Review