DANIELLA - Migrate configuration files from Java 8 to Java 11#7
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
DANIELLA - Migrate configuration files from Java 8 to Java 11#7devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- pom.xml: Update java.version to 11, Spring Boot to 2.7.18, add maven-compiler-plugin with release 11 - build.gradle: Update sourceCompatibility/targetCompatibility to 11, Spring Boot plugin to 2.7.18, migrate compile/testCompile to implementation/testImplementation, add missing jdbc and h2 dependencies - gradle-wrapper.properties: Upgrade Gradle from 4.6 to 7.6.4 (required by Spring Boot 2.7.x) - maven-wrapper.properties: Upgrade Maven from 3.3.9 to 3.6.3 - gs-spring-boot.iml: Update LANGUAGE_LEVEL to JDK_11 - .idea/misc.xml: Update languageLevel and project-jdk-name to 11 - .idea/compiler.xml: Update bytecode target to 11 - README.md: Update title and prerequisites to reflect Java 11 - gradlew/mvnw: Set executable permissions Co-Authored-By: Daniella Grimberg <daniella@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all build and IDE configuration files from Java 8 to Java 11. This also required upgrading Spring Boot (2.0.2 → 2.7.18), Gradle (4.6 → 7.6.4), and Maven wrapper (3.3.9 → 3.6.3) to versions that support Java 11.
Build configs:
pom.xml:java.version1.8→11, Spring Boot parent 2.0.2→2.7.18, addedmaven-compiler-pluginbuild.gradle:sourceCompatibility/targetCompatibility1.8→11, Spring Boot plugin 2.0.2→2.7.18, modernizedcompile→implementationsyntax (required by Gradle 7), addedspring-boot-starter-jdbcandh2deps (were in pom.xml but missing from Gradle)gradle-wrapper.properties: Gradle 4.6→7.6.4maven-wrapper.properties: Maven 3.3.9→3.6.3IDE files:
.idea/compiler.xml,.idea/misc.xml,gs-spring-boot.iml— JDK level 1.8→11Other: README updated,
gradlew/mvnwmade executable.Only Gradle
compileJavawas verified to pass. The app was not boot-tested at runtime.Review & Testing Checklist for Human
./gradlew bootRunand hit the key endpoints (GET /,GET /topic,GET /datetime).spring-boot-starter-jdbcandh2were added tobuild.gradleto fix a pre-existing compilation failure (they were already inpom.xmlbut missing from Gradle). This is a functional change beyond pure config migration.<packaging>pom</packaging>in pom.xml is intentional. This causes Maven to skip Java compilation entirely, meaning the Maven build path is untested. If Maven is meant to produce a runnable jar, this should bejar.maven-compiler-pluginconfig — it sets<source>,<target>, and<release>simultaneously, which is redundant.<release>11</release>alone is sufficient.gs-spring-boot.imlreferences stale library versions (Spring 5.0.6, Tomcat 8.5.31, etc. from the old Maven resolution). These won't match actual resolved versions after the upgrade — re-import the project in IntelliJ to refresh.Recommended test plan:
./gradlew bootRun, then via curl or Postman hitGET /topic,POST /topic,GET /datetimeto confirm the app serves correctly under Java 11 with the new Spring Boot version.Notes
spring-boot-properties-migratordependency (already in pom.xml) will log warnings at startup for any deprecated property usage — check those logs during testing.bootJar { baseName = ... }syntax inbuild.gradleis deprecated in Gradle 7 (replaced byarchiveBaseName). It still works but will emit a deprecation warning.Link to Devin session: https://app.devin.ai/sessions/4bdaef5e802f465fbb24c2e3baf90d60
Requested by: @danigrim