feat: 결제 두번째 모달 디자인#58
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR에서는 충전 프로세스를 위한 ConfirmChargeDrawer 컴포넌트를 신규 도입하고, 기존 상점 UI를 서브 컴포넌트로 분리하여 구조를 개선했습니다. 리뷰를 통해 ConfirmChargeDrawer 내 하드코딩된 기본값 수정과 한글 입력 시 UI 깨짐 방지를 위한 너비 조정을 제안했습니다. 또한, 보너스 아이템 판별 로직을 문자열 매칭 대신 데이터 필드 기반으로 개선하여 유지보수성을 확보할 것을 권장했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
결제 확인 모달(Drawer) 컴포넌트 신규 구현
상수 데이터 구조 API 응답 형식으로 리팩토링
개별/번들 아이템 렌더링 로직 컴포넌트화
입금 계좌 정보 및 입금자명 관리 기능 추가
Diagram Walkthrough
File Walkthrough
charge.ts
API 기반 데이터 구조로 전환 및 타입 정의lib/constants/charge.ts
QUICK_BUNDLES에priceValue필드 추가 (숫자 형식 가격)ITEM_PRICES,INDIVIDUAL_ITEMS,BUNDLE_ITEMS상수 제거Reward,ShopItemAPI신규 정의SHOP_ITEMS_API배열로 리팩토링BANK_INFO추가ConfirmChargeDrawer.tsx
계좌이체 결제 확인 모달 신규 구현components/common/charge-confirm/ConfirmChargeDrawer.tsx
QuickBundleCard.tsx
결제 모달 연동 및 Props 확장components/common/charge/QuickBundleCard.tsx
priceValue필드 추가ConfirmChargeDrawer로 래핑ShopContent.tsx
아이템 렌더링 로직 컴포넌트화 및 데이터 소스 통합components/common/charge/ShopContent.tsx
INDIVIDUAL_ITEMS,BUNDLE_ITEMS상수 제거SHOP_ITEMS_API기반 동적 필터링 로직 추가 (리워드 개수 기준)ShopItemRow,ShopBundleRow컴포넌트로 위임ShopRows.tsx
상점 아이템 행 컴포넌트 신규 구현components/common/charge/ShopRows.tsx
ShopItemRow컴포넌트 신규 구현 (개별 아이템 행)ShopBundleRow컴포넌트 신규 구현 (번들 아이템 행)ConfirmChargeDrawer통합✨ Describe tool usage guide:
Overview:
The
describetool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_descriptionsection), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describetool will run automatically on every PR.the tool will replace every marker of the form
pr_agent:marker_namein the PR description with the relevant content, wheremarker_nameis one of the following:type: the PR type.summary: the PR summary.walkthrough: the PR walkthrough.diagram: the PR sequence diagram (if enabled).Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describetool are quite generic: [Bug fix,Tests,Enhancement,Documentation,Other].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance- pr_agent:The main topic of this PR is performanceNew endpoint- pr_agent:A new endpoint was added in this PRSQL query- pr_agent:A new SQL query was added in this PRDockerfile changes- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describetool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summaryin the configuration file, possible values are:'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true: A collapsable file comment with changes title and a changes summary for each file in the PR.false(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describetool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.