feat: 조회하기 api 연결#60
Merged
Merged
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트에서는 구매 요청 상태를 조회하는 useRequestStatus 훅을 신설하고, 메인 페이지에서 구매 대기 상태에 따라 ChargeRequestWaiting 컴포넌트를 조건부로 노출하도록 구현했습니다. 또한 서버 사이드 프리페칭을 적용하고 매칭 리스트의 더미 데이터를 제거하는 등 전반적인 코드 정리도 함께 진행되었습니다. 리뷰에서는 컴포넌트에 흩어져 있는 비즈니스 로직(구매 대기 상태 판별)을 훅 내부로 캡슐화하여 가독성을 높일 것과, 데이터 플래트닝 과정에서 발생할 수 있는 런타임 에러를 방지하기 위해 옵셔널 체이닝을 보강할 것을 제안했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.