Feat/matchinglist api#61
Merged
Merged
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 사용자가 구체적인 나이 범위를 선택할 수 있는 AgeRangeDrawer와 MatchingAgeOption 컴포넌트를 추가하고, 기존 MatchingAgeSection과의 상태 연동 로직을 구현했습니다. 리뷰에서는 코드의 유지보수성과 웹 표준 준수를 위한 개선 사항들이 제안되었습니다. 주요 피드백으로는 AgeRangeDrawer 컴포넌트의 비대화(200줄 초과)에 따른 서브 컴포넌트 분리, 아이콘 버튼의 접근성(aria-label) 및 속성(type="button") 보완, 그리고 MatchingAgeSection을 제어 컴포넌트 패턴으로 리팩토링하여 부모 컴포넌트와의 상태 동기화 문제를 방지할 것이 포함되었습니다.
Comment on lines
+142
to
+148
| <button | ||
| onClick={decreaseMin} | ||
| disabled={localMin <= MIN_AGE} | ||
| className="flex h-9 w-9 items-center justify-center rounded-full border border-[#e5e5e5] bg-white transition-all active:scale-95 disabled:opacity-30" | ||
| > | ||
| <Minus size={16} className="text-color-text-black" /> | ||
| </button> |
Contributor
There was a problem hiding this comment.
아이콘으로만 구성된 버튼에는 접근성을 위해 aria-label을 추가하고, 의도치 않은 폼 제출을 방지하기 위해 type="button"을 명시하는 것이 좋습니다. 또한, 테두리 색상과 같은 정밀한 값은 Tailwind 임의 값 대신 인라인 스타일을 사용하세요.
<button
type="button"
onClick={decreaseMin}
disabled={localMin <= MIN_AGE}
aria-label="최소 나이 감소"
className="flex h-9 w-9 items-center justify-center rounded-full border bg-white transition-all active:scale-95 disabled:opacity-30" style={{ borderColor: "#e5e5e5" }}
>
References
- 아이콘 전용 버튼의 aria-label 확인 및 웹 표준 준수(type 명시) (link)
- Tailwind utility class로 정확히 표현하기 어려운 border, box-shadow 등의 값은 인라인 스타일을 사용합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.