Feat/other api#64
Merged
Merged
Conversation
Contributor
Author
|
@gemini-code-assist review |
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 관리자 공지사항 관리 기능(CRUD) 추가와 사용자 충전 내역의 필터링 및 무한 스크롤 구현을 주요 골자로 합니다. 또한 로컬 개발 환경에서의 쿠키 저장 문제를 해결하기 위해 도메인 처리 로직을 개선하고, 충전 대기 UI에 수동 갱신 기능을 도입했습니다. 코드 리뷰에서는 저장소 스타일 가이드에 따라 데이터 변이 시 Server Actions 활용, 거대 컴포넌트의 서브 컴포넌트 분리, 폼 요소의 웹 접근성 개선, 그리고 재사용 가능한 헬퍼 함수의 유틸리티화가 필요하다는 의견이 제시되었습니다.
Comment on lines
+40
to
+48
| const createNotice = async ( | ||
| body: CreateNoticeBody, | ||
| ): Promise<ApiResponse<null>> => { | ||
| const { data } = await api.post<ApiResponse<null>>( | ||
| "/api/v1/admin/notices", | ||
| body, | ||
| ); | ||
| return data; | ||
| }; |
Contributor
There was a problem hiding this comment.
저장소 스타일 가이드(43번 항목)에 따라, API Route 대신 Server Actions를 사용하여 데이터 변이(Mutation)를 처리하는 것을 권장합니다. 현재는 axios를 통해 직접 API를 호출하고 있으나, 이를 Next.js Server Action으로 전환하여 구현하는 것을 고려해 보세요.
References
- API Route 대신 Server Actions를 사용하여 데이터 변이(Mutation)를 처리해야 함. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
관리자 공지사항 등록/수정/삭제 기능 추가
충전 내역 API 연결 및 무한 스크롤 구현
충전 대기 상태 해제 시 아이템 캐시 자동 갱신
충전 대기 중 수동 새로고침 버튼 추가
Diagram Walkthrough
File Walkthrough
11 files
관리자 공지사항 CRUD 훅 구현충전 내역 무한 쿼리 훅 추가충전 완료 감지 시 캐시 갱신 로직공지사항 관리 메뉴 아이템 추가공지사항 관리 페이지 UI 구현공지사항 페이지 서버 사이드 프리페칭충전 대기 중 수동 새로고침 버튼탭 스크롤 시 레이아웃 개선충전 내역 API 연결 및 필터 기능충전 내역 아이템 동적 렌더링보너스 텍스트 표시 로직 개선1 files
상품명 타이포그래피 미세 조정✨ Describe tool usage guide:
Overview:
The
describetool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_descriptionsection), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describetool will run automatically on every PR.the tool will replace every marker of the form
pr_agent:marker_namein the PR description with the relevant content, wheremarker_nameis one of the following:type: the PR type.summary: the PR summary.walkthrough: the PR walkthrough.diagram: the PR sequence diagram (if enabled).Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describetool are quite generic: [Bug fix,Tests,Enhancement,Documentation,Other].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance- pr_agent:The main topic of this PR is performanceNew endpoint- pr_agent:A new endpoint was added in this PRSQL query- pr_agent:A new SQL query was added in this PRDockerfile changes- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describetool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summaryin the configuration file, possible values are:'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true: A collapsable file comment with changes title and a changes summary for each file in the PR.false(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describetool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.