Skip to content

Feat/other api#64

Merged
dasosann merged 9 commits into
mainfrom
feat/other-api
May 12, 2026
Merged

Feat/other api#64
dasosann merged 9 commits into
mainfrom
feat/other-api

Conversation

@dasosann

@dasosann dasosann commented May 11, 2026

Copy link
Copy Markdown
Contributor

PR Type

Enhancement


Description

  • 관리자 공지사항 등록/수정/삭제 기능 추가

  • 충전 내역 API 연결 및 무한 스크롤 구현

  • 충전 대기 상태 해제 시 아이템 캐시 자동 갱신

  • 충전 대기 중 수동 새로고침 버튼 추가


Diagram Walkthrough

flowchart LR
  A["관리자 공지사항 관리"] --> B["CRUD 훅<br/>useAdminNotices"]
  B --> C["공지사항 페이지<br/>AdminNotices"]
  D["충전 내역 API"] --> E["무한 쿼리 훅<br/>useItemHistory"]
  E --> F["충전 내역 컴포넌트<br/>ChargeHistoryContent"]
  G["충전 대기 상태 감지"] --> H["캐시 자동 갱신<br/>items, itemHistory"]
  I["수동 새로고침"] --> J["상태 폴링<br/>useRequestStatus"]
Loading

File Walkthrough

Relevant files
Enhancement
11 files
useAdminNotices.ts
관리자 공지사항 CRUD 훅 구현                                                                             
+135/-0 
useItemHistory.ts
충전 내역 무한 쿼리 훅 추가                                                                                 
+70/-0   
useRequestStatus.ts
충전 완료 감지 시 캐시 갱신 로직                                                                           
+15/-1   
AdminMainScreen.tsx
공지사항 관리 메뉴 아이템 추가                                                                               
+10/-0   
AdminNotices.tsx
공지사항 관리 페이지 UI 구현                                                                               
+424/-0 
page.tsx
공지사항 페이지 서버 사이드 프리페칭                                                                         
+27/-0   
ChargeRequestWaiting.tsx
충전 대기 중 수동 새로고침 버튼                                                                             
+17/-4   
ChargeDrawer.tsx
탭 스크롤 시 레이아웃 개선                                                                                   
+7/-3     
ChargeHistoryContent.tsx
충전 내역 API 연결 및 필터 기능                                                                         
+60/-13 
ChargeHistoryListItem.tsx
충전 내역 아이템 동적 렌더링                                                                                 
+32/-37 
QuickBundleCard.tsx
보너스 텍스트 표시 로직 개선                                                                                 
+8/-6     
Formatting
1 files
ShopRows.tsx
상품명 타이포그래피 미세 조정                                                                                 
+1/-1     


✨ Describe tool usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...
Enabling\disabling automation
  • When you first install the app, the default mode for the describe tool is:
pr_commands = ["/describe", ...]

meaning the describe tool will run automatically on every PR.

  • Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:
pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

  • type: the PR type.
  • summary: the PR summary.
  • walkthrough: the PR walkthrough.
  • diagram: the PR sequence diagram (if enabled).

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels

The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].

If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

  • Main topic:performance - pr_agent:The main topic of this PR is performance
  • New endpoint - pr_agent:A new endpoint was added in this PR
  • SQL query - pr_agent:A new SQL query was added in this PR
  • Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
  • ...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Inline File Walkthrough 💎

For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).

To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

  • 'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
  • true: A collapsable file comment with changes title and a changes summary for each file in the PR.
  • false (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions

The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.

Examples for extra instructions:

[pr_description]
extra_instructions="""- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /help_docs <QUESTION>: Given a path to documentation (either for this repository or for a given one), ask a question.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

@qodo-code-review qodo-code-review Bot added the enhancement New feature or request label May 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 풀 리퀘스트는 관리자 공지사항 관리 기능(CRUD)과 사용자 충전 내역의 필터링 및 무한 스크롤 기능을 도입합니다. 리뷰 결과, 웹 접근성 향상을 위한 label-input 연결 및 아이콘 버튼의 aria-label 추가가 필요하며, 유지보수성을 위해 200줄이 넘는 컴포넌트 분리와 공통 날짜 포맷팅 로직의 유틸리티화가 권장되었습니다. 또한, 구현된 기능과 일치하지 않는 주석을 수정하라는 피드백이 있었습니다.

Comment thread app/adminpage/notices/_components/AdminNotices.tsx Outdated
Comment thread app/adminpage/notices/_components/AdminNotices.tsx
Comment thread app/adminpage/notices/_components/AdminNotices.tsx
Comment thread app/adminpage/notices/_components/AdminNotices.tsx
Comment thread components/common/charge/ChargeHistoryContent.tsx
@dasosann

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 풀 리퀘스트는 관리자 공지사항 관리 기능(CRUD) 추가와 사용자 충전 내역의 필터링 및 무한 스크롤 구현을 주요 골자로 합니다. 또한 로컬 개발 환경에서의 쿠키 저장 문제를 해결하기 위해 도메인 처리 로직을 개선하고, 충전 대기 UI에 수동 갱신 기능을 도입했습니다. 코드 리뷰에서는 저장소 스타일 가이드에 따라 데이터 변이 시 Server Actions 활용, 거대 컴포넌트의 서브 컴포넌트 분리, 폼 요소의 웹 접근성 개선, 그리고 재사용 가능한 헬퍼 함수의 유틸리티화가 필요하다는 의견이 제시되었습니다.

Comment thread hooks/admin/useAdminNotices.ts Outdated
Comment on lines +40 to +48
const createNotice = async (
body: CreateNoticeBody,
): Promise<ApiResponse<null>> => {
const { data } = await api.post<ApiResponse<null>>(
"/api/v1/admin/notices",
body,
);
return data;
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

저장소 스타일 가이드(43번 항목)에 따라, API Route 대신 Server Actions를 사용하여 데이터 변이(Mutation)를 처리하는 것을 권장합니다. 현재는 axios를 통해 직접 API를 호출하고 있으나, 이를 Next.js Server Action으로 전환하여 구현하는 것을 고려해 보세요.

References
  1. API Route 대신 Server Actions를 사용하여 데이터 변이(Mutation)를 처리해야 함. (link)

Comment thread app/adminpage/notices/_components/AdminNotices.tsx
Comment thread app/adminpage/notices/_components/AdminNotices.tsx
Comment thread app/adminpage/notices/_components/AdminNotices.tsx
@dasosann dasosann merged commit 4b8db27 into main May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant