Skip to content

Fix/token#65

Merged
dasosann merged 3 commits into
mainfrom
fix/token
May 12, 2026
Merged

Fix/token#65
dasosann merged 3 commits into
mainfrom
fix/token

Conversation

@dasosann

@dasosann dasosann commented May 12, 2026

Copy link
Copy Markdown
Contributor

PR Type

Enhancement


Description

  • 쿠키 처리 로직을 serverApi 내부로 이동하여 중복 제거

  • 회원 탈퇴 기능 구현 및 API 연결

  • 탈퇴 시 로컬 토큰 자동 삭제 처리


Diagram Walkthrough

flowchart LR
  A["로그인 요청"] -->|setCookie 제거| B["serverApi 내부 처리"]
  B -->|쿠키 자동 저장| C["중복 코드 제거"]
  D["탈퇴 버튼 클릭"] -->|withdrawAction 호출| E["API 요청"]
  E -->|성공| F["토큰 삭제"]
  F -->|리다이렉트| G["홈페이지"]
Loading

File Walkthrough

Relevant files
Refactoring
loginAction.ts
로그인 쿠키 처리 로직 제거                                                                                   

lib/actions/loginAction.ts

  • 로그인 후 쿠키 설정 로직 제거 (약 50줄)
  • serverApi.post 내부에서 이미 처리되므로 중복 제거
  • 주석으로 변경 사항 명시
+2/-49   
adminLoginAction.ts
관리자 로그인 쿠키 처리 로직 제거                                                                           

lib/actions/admin/adminLoginAction.ts

  • 관리자 로그인 후 쿠키 설정 로직 제거 (약 50줄)
  • serverApi.post 내부 처리로 통일
  • 중복 코드 제거로 유지보수성 향상
+2/-48   
Enhancement
authAction.ts
회원 탈퇴 Server Action 구현                                                                     

lib/actions/authAction.ts

  • withdrawAction 새로운 Server Action 추가
  • WithdrawResponse 타입 정의
  • 탈퇴 API 호출 및 로컬 토큰 삭제 처리
  • 에러 핸들링 및 사용자 피드백 구현
+45/-0   
ScreenMyPage.tsx
탈퇴 버튼 기능 구현 및 UX 개선                                                                           

app/mypage/_components/ScreenMyPage.tsx

  • 탈퇴 버튼에 withdrawAction 연결
  • 제출 중 버튼 비활성화 처리 추가
  • 탈퇴 확인 메시지 개선
  • 성공/실패 시 사용자 안내 및 리다이렉트 처리
+17/-4   


✨ Describe tool usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...
Enabling\disabling automation
  • When you first install the app, the default mode for the describe tool is:
pr_commands = ["/describe", ...]

meaning the describe tool will run automatically on every PR.

  • Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:
pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

  • type: the PR type.
  • summary: the PR summary.
  • walkthrough: the PR walkthrough.
  • diagram: the PR sequence diagram (if enabled).

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels

The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].

If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

  • Main topic:performance - pr_agent:The main topic of this PR is performance
  • New endpoint - pr_agent:A new endpoint was added in this PR
  • SQL query - pr_agent:A new SQL query was added in this PR
  • Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
  • ...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Inline File Walkthrough 💎

For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).

To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

  • 'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
  • true: A collapsable file comment with changes title and a changes summary for each file in the PR.
  • false (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions

The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.

Examples for extra instructions:

[pr_description]
extra_instructions="""- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /help_docs <QUESTION>: Given a path to documentation (either for this repository or for a given one), ask a question.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

@qodo-code-review qodo-code-review Bot added the enhancement New feature or request label May 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 풀 리퀘스트에서는 회원 탈퇴 기능을 위한 Server Action과 UI 로직을 추가하고, serverApi 내부에서 쿠키 처리가 통합됨에 따라 기존 로그인 액션들의 중복된 쿠키 파싱 로직을 제거하였습니다. 리뷰 피드백으로는 ScreenMyPage 컴포넌트가 스타일 가이드의 200라인 제한을 크게 초과하여 컴포넌트 분리가 필요하다는 점이 지적되었습니다. 또한, 탈퇴 처리 시 isSubmitting 상태 관리의 미흡함과 Server Action의 동적 임포트 방식 개선, 그리고 Next.js의 SPA 특성을 유지하기 위해 window.location.href 대신 useRouter를 사용할 것이 권장되었습니다.

Comment thread app/mypage/_components/ScreenMyPage.tsx
Comment thread app/mypage/_components/ScreenMyPage.tsx Outdated
Comment thread app/mypage/_components/ScreenMyPage.tsx Outdated
@dasosann dasosann merged commit 9db94fd into main May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant