Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트에서는 회원 탈퇴 기능을 위한 Server Action과 UI 로직을 추가하고, serverApi 내부에서 쿠키 처리가 통합됨에 따라 기존 로그인 액션들의 중복된 쿠키 파싱 로직을 제거하였습니다. 리뷰 피드백으로는 ScreenMyPage 컴포넌트가 스타일 가이드의 200라인 제한을 크게 초과하여 컴포넌트 분리가 필요하다는 점이 지적되었습니다. 또한, 탈퇴 처리 시 isSubmitting 상태 관리의 미흡함과 Server Action의 동적 임포트 방식 개선, 그리고 Next.js의 SPA 특성을 유지하기 위해 window.location.href 대신 useRouter를 사용할 것이 권장되었습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
쿠키 처리 로직을
serverApi내부로 이동하여 중복 제거회원 탈퇴 기능 구현 및 API 연결
탈퇴 시 로컬 토큰 자동 삭제 처리
Diagram Walkthrough
File Walkthrough
loginAction.ts
로그인 쿠키 처리 로직 제거lib/actions/loginAction.ts
serverApi.post내부에서 이미 처리되므로 중복 제거adminLoginAction.ts
관리자 로그인 쿠키 처리 로직 제거lib/actions/admin/adminLoginAction.ts
serverApi.post내부 처리로 통일authAction.ts
회원 탈퇴 Server Action 구현lib/actions/authAction.ts
withdrawAction새로운 Server Action 추가WithdrawResponse타입 정의ScreenMyPage.tsx
탈퇴 버튼 기능 구현 및 UX 개선app/mypage/_components/ScreenMyPage.tsx
withdrawAction연결✨ Describe tool usage guide:
Overview:
The
describetool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_descriptionsection), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describetool will run automatically on every PR.the tool will replace every marker of the form
pr_agent:marker_namein the PR description with the relevant content, wheremarker_nameis one of the following:type: the PR type.summary: the PR summary.walkthrough: the PR walkthrough.diagram: the PR sequence diagram (if enabled).Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describetool are quite generic: [Bug fix,Tests,Enhancement,Documentation,Other].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance- pr_agent:The main topic of this PR is performanceNew endpoint- pr_agent:A new endpoint was added in this PRSQL query- pr_agent:A new SQL query was added in this PRDockerfile changes- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describetool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summaryin the configuration file, possible values are:'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true: A collapsable file comment with changes title and a changes summary for each file in the PR.false(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describetool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.