Skip to content

Fix/qa#66

Merged
dasosann merged 4 commits into
mainfrom
fix/qa
May 13, 2026
Merged

Fix/qa#66
dasosann merged 4 commits into
mainfrom
fix/qa

Conversation

@dasosann

@dasosann dasosann commented May 13, 2026

Copy link
Copy Markdown
Contributor

PR Type

Enhancement, Bug fix


Description

  • 구매 한도 조회 API 연결 및 UI 반영

  • 중요 옵션에서 나이 옵션 제거 및 애니메이션 오류 해결

  • 취미 카테고리 "예술"을 "음악"으로 통일

  • 실명 조회/수정 기능 개선 및 입금자명 자동 로드


Diagram Walkthrough

flowchart LR
  A["구매 한도 API<br/>usePurchaseLimits"] --> B["충전 확인 드로어<br/>ConfirmChargeDrawer"]
  A --> C["인벤토리 카드<br/>ChargeInventoryCard"]
  D["실명 조회 API<br/>useRealName"] --> E["입금자명 입력<br/>DepositorNameContent"]
  F["중요 옵션<br/>ImportantOptionDrawer"] --> G["나이 옵션 제거<br/>드래그 애니메이션 수정"]
  H["취미 카테고리<br/>상수 통일"] --> I["매칭 화면<br/>프로필 이미지"]
Loading

File Walkthrough

Relevant files
Enhancement
10 files
usePurchaseLimits.ts
구매 한도 조회 API 훅 신규 추가                                                                         
+44/-0   
useRealName.ts
사용자 실명 조회 API 훅 신규 추가                                                                       
+31/-0   
hobbies.ts
취미 카테고리 "예술"을 "음악"으로 변경                                                                   
+1/-1     
matchingInterests.ts
매칭 관심사 카테고리 "예술"을 "음악"으로 통일                                                           
+2/-2     
matching.ts
중요 옵션 타입에서 AGE 제거                                                                               
+1/-1     
ScreenMatching.tsx
취미 매핑 "예술"을 "음악"으로 변경                                                                       
+1/-2     
TermsDrawer.tsx
취미 매핑 "예술"을 "음악"으로 변경                                                                       
+1/-1     
ConfirmChargeDrawer.tsx
구매 한도 검증 로직 및 리워드 정보 추가                                                                   
+54/-4   
ChargeInventoryCard.tsx
API 기반 구매 한도 표시 및 대기중 수량 표시                                                           
+44/-24 
DepositorNameContent.tsx
실명 조회 API 연결 및 자동 로드 기능                                                                   
+12/-3   
Bug fix
4 files
useUpdateRealName.ts
실명 수정 후 쿼리 캐시 무효화 추가                                                                         
+1/-2     
ScreenMatchingResult.tsx
뒤로가기 버튼 클릭 핸들러 추가                                                                               
+1/-0     
ImportantOptionDrawer.tsx
나이 옵션 제거 및 드래그 애니메이션 수정                                                                   
+0/-3     
MatchingOptionCard.tsx
클릭 핸들러 제거 및 터치 패닝 개선                                                                         
+1/-2     
Documentation
1 files
HobbyEditDrawer.tsx
주석 업데이트 "예술"을 "음악"으로 변경                                                                   
+1/-1     


✨ Describe tool usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...
Enabling\disabling automation
  • When you first install the app, the default mode for the describe tool is:
pr_commands = ["/describe", ...]

meaning the describe tool will run automatically on every PR.

  • Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:
pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

  • type: the PR type.
  • summary: the PR summary.
  • walkthrough: the PR walkthrough.
  • diagram: the PR sequence diagram (if enabled).

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels

The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].

If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

  • Main topic:performance - pr_agent:The main topic of this PR is performance
  • New endpoint - pr_agent:A new endpoint was added in this PR
  • SQL query - pr_agent:A new SQL query was added in this PR
  • Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
  • ...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Inline File Walkthrough 💎

For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).

To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

  • 'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
  • true: A collapsable file comment with changes title and a changes summary for each file in the PR.
  • false (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions

The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.

Examples for extra instructions:

[pr_description]
extra_instructions="""- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /help_docs <QUESTION>: Given a path to documentation (either for this repository or for a given one), ask a question.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

@qodo-code-review qodo-code-review Bot added enhancement New feature or request Bug fix labels May 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 PR은 매칭 시스템에서 나이 옵션을 제거하고 '예술' 카테고리를 '음악'으로 변경하는 명칭 정리를 수행했습니다. 기능적으로는 충전 확인 프로세스에 구매 한도 확인 로직을 추가하고, 실명 조회 API를 통해 입금자명을 자동으로 입력하는 기능을 구현했습니다. 리뷰 의견으로는 useRealName 훅의 디버깅 로그 제거, ConfirmChargeDrawer 내 복잡한 조건부 렌더링 로직의 가독성 개선, 그리고 DepositorNameContent에서 useEffect 의존성 설정 오류로 인해 발생할 수 있는 입력값 초기화 버그 수정을 요청했습니다.

Comment thread hooks/useRealName.ts
Comment thread components/common/charge-confirm/ConfirmChargeDrawer.tsx Outdated
Comment thread components/common/charge/DepositorNameContent.tsx Outdated
@dasosann dasosann merged commit 87f910d into main May 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug fix enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant