Misc 20260904 fixes - #8
Merged
Merged
Conversation
jasonsopko
approved these changes
Sep 5, 2026
jasonsopko
left a comment
There was a problem hiding this comment.
Tested ACK cd91837
Ubuntu 24.04, gcc 13.3, clang 18.1, on master b9ea7dc. gcc and clang with -Wall -Werror, ENABLE_API=OFF, DATUM_API_FOR_UMBREL and ASan all build clean and pass --test. The UBSan run stops at the pre-existing misaligned store in datum_protocol_tests.c:133; with #5 cherry-picked on top it passes.
Notes from reading the three commits:
- The leak fix is latent today: the only caller (
datum_protocol.c:1355) passesmust_free=false. Correct either way. outval > s->coinbase_value - tallyis safe becausetallyonly grows by values that already passed the check, so it never exceedscoinbase_value. The new test covers the overflow case.- The vardiff move fixes a real first-notify problem. The client slot is zeroed on connect, so
stratum_update_vardiff()inside the firstsend_mining_notify()sawshare_snap_tsms == 0, read that as more than 60 s without shares, and halvedcurrent_diffbefore theforced_high_min_diff/vardiff_minclamps. Starting the snapshot before the notify makes that pass a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.