Frontend Fixes - #343
Merged
Merged
Frontend Fixes#343
Conversation
… so im gonna try making a custom drop down instead
…o patch/ui-Taskeen
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Swe-yy
requested changes
Sep 14, 2026
Swe-yy
left a comment
Swe-yy
left a comment
Contributor
There was a problem hiding this comment.
I'm still not seeing loading states on the sign in, sign up and log out buttons.
i'm only seeing it on the confirmation code page
Contributor
Maybe increase the width of the buttons ? They seem a bit skinny
|
Contributor
Typo in the "Create an account" button 🙏 |
|
nsmzoneli
approved these changes
Sep 15, 2026
nsmzoneli
left a comment
nsmzoneli
left a comment
Contributor
There was a problem hiding this comment.
all the UI changes that the PR seeks to merge in are there and working.
Swe-yy
approved these changes
Sep 16, 2026
Swe-yy
left a comment
Swe-yy
left a comment
Contributor
There was a problem hiding this comment.
The buttons have visible loading states now and the styling updates look great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge frontend fixes for:
Related issue
How to test
cd frontend
npm install country-flag-icons