feat(f1): 독립 pairing validator (C1/C2/C4/C5) 구현 - #32
Open
ohchanju3 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
F1(V1) 중 찬주 담당 파트) — 생성 코드와 독립적인 pairing legality validator, source_type별 분리 집계, LLM adapter 구현.
포함된 것
RL/environment.py::get_mask()를 재사용하지 않고 14개 violation code(base 출발/복귀, duty 내외 공항 연속성, connection/rest 시간, duty·leg·pairing 기간, duplicate, unknown flight 등)를 전부 새로 구현. Turkish HB1/HB2 비대칭 복귀(allowed_return_basesopt-in)도 지원aggregate_by_source()로 policy_direct/ salvage/repair/forced 4종류 분리 집계(pairing 수, coverage, invalid 수, duplicate, deadhead 수, ManDays, FTC — 전부 flights 데이터로 독립 재계산).aggregate_by_source_per_chunk()로 chunk마다 base가 다른 경우도 대응.validator_version/constraint_hash를 검증 결과에 기록.tests/test_validator.py,test_validation_report.py,test_llm_adapter.py).아직 안 된 것 (혜린 코드 필요)
evaluate_ip.py/eval_best.py실제 연결(C3) — 실제 pairing pool 출력 형태 확인 후 진행MIN_REST_FAILURE1개 violation code — pairing_record가 duty 경계를 명시적으로 주는지에 따라 구현 방식 달라짐, TODO로 문서화(evaluation/validator.py주석 참고)확인 필요(merge 후 재검토 예정)
allowed_return_bases필드명이 Turkish constraint 쪽 구현과 맞는지