Improve AI broker retry logs for rate-limit fixed wait handling#836
Open
GVCUTV wants to merge 1 commit intoissue665-iterative-correctionfrom
Open
Improve AI broker retry logs for rate-limit fixed wait handling#836GVCUTV wants to merge 1 commit intoissue665-iterative-correctionfrom
GVCUTV wants to merge 1 commit intoissue665-iterative-correctionfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
provider,attempt,correlation_id,error_code,backoff_ms) so automated tooling and runbooks can surface and filter relevant events.Description
src/main/java/org/cswteams/ms3/ai/broker/AgentBrokerImpl.javato includeproviderinai_broker_attempt_failedlogs and to consistently emit structured fields forprovider,attempt,correlation_id, anderror_codeacross retry paths.event=ai_broker_rate_limit_fixed_wait(withwait_reason=rate_limit_window_reset_429) for the GEMMA 60s forced wait, separate from normal retry backoff events.event=ai_broker_retry_backoffwithwait_reason=normal_retry_backofforwait_reason=rate_limit_backoff, and the dedicatedai_broker_rate_limit_fixed_waitfor forced 429 waits, and included explicitbackoff_msin these messages.getErrorCode(...)helper to normalize extraction of anerror_codestring for logs and updated theai_broker_rate_limit_retry_skippedlog to includeprovideranderror_code.docs/AI_powered_rescheduling/sprint_4/story_5.mdto document the new event taxonomy and guidance for incident handling (how to distinguish normal retry backoff vs forced 429 window reset waits).Testing
mvn -q -Dtest=AgentBrokerImplTest test, but the build could not complete in this environment because Maven failed to resolve the parent POM from Maven Central (HTTP 403), so tests could not be executed to completion.Codex Task