Draft
Conversation
…ware into feature-new-rust-config
…eanup sensor manager, send CAN motor states over comms
|
Doxygen warnings output: (if empty, there are no warnings). Please correct any warnings before merging. /github/workspace/src/controls/state.hpp:5: warning: Found ';' while parsing initializer list! (doxygen could be confused by a macro call without semicolon)
/github/workspace/src/sensors/rev_encoder.hpp:46: warning: More #endif's than #if's found.
/github/workspace/src/sensors/rev_encoder.hpp:46: warning: More #endif's than #if's found.
/github/workspace/src/comms/data/motor_state_data.hpp:1: warning: Compound MotorStateData is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:45: warning: Compound NewConfig::BuffEncoder is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:28: warning: Compound NewConfig::ConfigStart is not documented.
/github/workspace/src/comms/config_data/controller.hpp:63: warning: Compound NewConfig::Controller is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:110: warning: Compound NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/controller.hpp:39: warning: Compound NewConfig::Gains is not documented.
/github/workspace/src/comms/config_data/controller.hpp:48: warning: Compound NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/estimator.hpp:25: warning: Compound NewConfig::HighLevelEstimator is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:76: warning: Compound NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/estimator.hpp:16: warning: Compound NewConfig::LowLevelEstimator is not documented.
/github/workspace/src/comms/config_data/motor.hpp:42: warning: Compound NewConfig::Motor is not documented.
/github/workspace/src/comms/config_data/state.hpp:28: warning: Compound NewConfig::ReferenceLimit is not documented.
/github/workspace/src/comms/config_data/state.hpp:22: warning: Compound NewConfig::ReferenceLimits is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:38: warning: Compound NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/state.hpp:33: warning: Compound NewConfig::State is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:146: warning: Compound NewConfig::StereoCamTrigger is not documented.
/github/workspace/src/comms/config_data/controller.hpp:58: warning: Compound NewConfig::SubController is not documented.
/github/workspace/src/controls/robot_state_map.hpp:6: warning: Compound RobotStateMap is not documented.
/github/workspace/src/controls/state.hpp:3: warning: Compound State is not documented.
/github/workspace/src/controls/controller.cpp:5: warning: no uniquely matching class member found for
void XDriveController::step(RobotStateMap reference_map, RobotStateMap estimate_map, float outputs[CAN_MAX_MOTORS])
/github/workspace/src/controls/estimator.cpp:32: warning: no uniquely matching class member found for
void GimbalEstimatorNoOdom::step_states(float output[STATE_LEN][3], float curr_state[STATE_LEN][3], int override)
/github/workspace/src/controls/estimator.cpp:234: warning: documented symbol 'ActuatorEstimator::ActuatorEstimator' was not declared or defined.
/github/workspace/src/controls/estimator.cpp:239: warning: no uniquely matching class member found for
void ActuatorEstimator::step_states(float output[CAN_MAX_MOTORS][MICRO_STATE_LEN], float curr_state[CAN_MAX_MOTORS][MICRO_STATE_LEN], int override)
/github/workspace/src/controls/estimator_manager.cpp:23: warning: no matching class member found for
void EstimatorManager::init_estimator(NewConfig::HighLevelEstimator estimator_config, const CANManager &can, const SensorManager &sensor_manager)
Possible candidates:
'void EstimatorManager::init_estimator(const NewConfig::HighLevelEstimator &estimator_config, const CANManager &can, const SensorManager &sensor_manager)'
'void EstimatorManager::init_estimator(const NewConfig::LowLevelEstimator &estimator_config, const CANManager &can, const SensorManager &sensor_manager)'
/github/workspace/src/controls/reference_governer.cpp:5: warning: documented symbol 'void Governor::set_raw_reference' was not declared or defined.
/github/workspace/src/controls/state.cpp:3: warning: documented symbol 'State::State' was not declared or defined.
/github/workspace/src/sensors/AdafruitIMUSensor.cpp:4: warning: no uniquely matching class member found for
void IMUSensor::print()
/github/workspace/src/sensors/ICM20649.hpp:18: warning: unable to resolve reference to 'init(CommunicationProtocol)' for \ref command
/github/workspace/src/sensors/ICM20649.hpp:25: warning: @copybrief or @copydoc target 'IMUSensor::read()' not found
/github/workspace/src/sensors/buff_encoder.hpp:63: warning: Member get_name() const (function) of class BuffEncoder is not documented.
/github/workspace/src/sensors/buff_encoder.hpp:65: warning: Member get_data_for_comms() (function) of class BuffEncoder is not documented.
/github/workspace/src/sensors/can/can_manager.hpp:74: warning: Member send_to_comms() (function) of class CANManager is not documented.
/github/workspace/src/sensors/can/can_manager.hpp:63: warning: argument 'motor_info' of command @param is not found in the argument list of CANManager::configure_motor(const NewConfig::Motor &motor_config)
/github/workspace/src/sensors/can/can_manager.hpp:65: warning: The following parameter of CANManager::configure_motor(const NewConfig::Motor &motor_config) is not documented:
parameter 'motor_config'
/github/workspace/src/sensors/can/can_manager.hpp:61: warning: parameters of member CANManager::init are not (all) documented
/github/workspace/src/controls/controller.hpp:26: warning: parameters of member Controller::Controller are not (all) documented
/github/workspace/src/controls/controller.hpp:38: warning: Member config() const (function) of struct Controller is not documented.
/github/workspace/src/controls/controller_manager.hpp:19: warning: parameters of member ControllerManager::ControllerManager are not (all) documented
/github/workspace/src/controls/controller_manager.hpp:12: warning: Member controllers (variable) of class ControllerManager is not documented.
/github/workspace/src/controls/controller_manager.hpp:21: warning: argument '_can' of command @param is not found in the argument list of ControllerManager::init(const std::vector< NewConfig::Controller > &controller_configurations)
/github/workspace/src/controls/controller_manager.hpp:21: warning: argument '_config_data' of command @param is not found in the argument list of ControllerManager::init(const std::vector< NewConfig::Controller > &controller_configurations)
/github/workspace/src/controls/controller_manager.hpp:24: warning: The following parameter of ControllerManager::init(const std::vector< NewConfig::Controller > &controller_configurations) is not documented:
parameter 'controller_configurations'
/github/workspace/src/sensors/d200.hpp:157: warning: Member validate_port(std::optional< HardwareSerial * > port_opt) (function) of class D200LD14P is not documented.
/github/workspace/src/sensors/d200.hpp:114: warning: Member config (variable) of class D200LD14P is not documented.
/github/workspace/src/sensors/d200.hpp:160: warning: argument '_port' of command @param is not found in the argument list of D200LD14P::D200LD14P(const NewConfig::D200Lidar &config)
/github/workspace/src/sensors/d200.hpp:160: warning: argument '_id' of command @param is not found in the argument list of D200LD14P::D200LD14P(const NewConfig::D200Lidar &config)
/github/workspace/src/sensors/d200.hpp:163: warning: The following parameter of D200LD14P::D200LD14P(const NewConfig::D200Lidar &config) is not documented:
parameter 'config'
/github/workspace/src/sensors/Transmitter.hpp:233: warning: Member send_to_comms() (function) of class Transmitter is not documented.
/github/workspace/src/controls/estimator_manager.hpp:47: warning: Member init_estimator(const NewConfig::HighLevelEstimator &estimator_config, const CANManager &can, const SensorManager &sensor_manager) (function) of class EstimatorManager is not documented.
/github/workspace/src/controls/estimator_manager.hpp:49: warning: Member init_estimator(const NewConfig::LowLevelEstimator &estimator_config, const CANManager &can, const SensorManager &sensor_manager) (function) of class EstimatorManager is not documented.
/github/workspace/src/controls/estimator_manager.hpp:18: warning: Member high_level_estimators (variable) of class EstimatorManager is not documented.
/github/workspace/src/controls/estimator_manager.hpp:19: warning: Member low_level_estimators (variable) of class EstimatorManager is not documented.
/github/workspace/src/controls/estimator_manager.hpp:28: warning: argument 'can' of command @param is not found in the argument list of EstimatorManager::init(const std::vector< NewConfig::Estimator > &estimator_configurations)
/github/workspace/src/controls/estimator_manager.hpp:28: warning: argument 'config_data' of command @param is not found in the argument list of EstimatorManager::init(const std::vector< NewConfig::Estimator > &estimator_configurations)
/github/workspace/src/controls/estimator_manager.hpp:28: warning: argument 'sensor_manager' of command @param is not found in the argument list of EstimatorManager::init(const std::vector< NewConfig::Estimator > &estimator_configurations)
/github/workspace/src/controls/estimator_manager.hpp:32: warning: The following parameter of EstimatorManager::init(const std::vector< NewConfig::Estimator > &estimator_configurations) is not documented:
parameter 'estimator_configurations'
/github/workspace/src/sensors/Transmitter.hpp:233: warning: Member send_to_comms() (function) of class Transmitter is not documented.
/github/workspace/src/controls/controller.hpp:304: warning: Member step(RobotStateMap reference_map, RobotStateMap estimate_map, float outputs[CAN_MAX_MOTORS]) (function) of struct FeederController is not documented.
/github/workspace/src/controls/controller.hpp:26: warning: parameters of member Controller::Controller are not (all) documented
/github/workspace/src/controls/controller.hpp:38: warning: Member config() const (function) of struct Controller is not documented.
/github/workspace/src/controls/controller.hpp:285: warning: Member full_state_position_controller (variable) of struct FeederController is not documented.
/github/workspace/src/controls/controller.hpp:286: warning: Member full_state_velocity_controller (variable) of struct FeederController is not documented.
/github/workspace/src/controls/controller.hpp:26: warning: parameters of member Controller::Controller are not (all) documented
/github/workspace/src/controls/controller.hpp:38: warning: Member config() const (function) of struct Controller is not documented.
/github/workspace/src/controls/controller.hpp:221: warning: Member high_level_velocity_controller (variable) of struct FlywheelController is not documented.
/github/workspace/src/controls/controller.hpp:222: warning: Member low_level_velocity_controller (variable) of struct FlywheelController is not documented.
/github/workspace/src/controls/estimator.hpp:252: warning: Member buff_enc_yaw (variable) of struct GimbalAndChassisEstimator is not documented.
/github/workspace/src/controls/estimator.hpp:253: warning: Member buff_enc_pitch (variable) of struct GimbalAndChassisEstimator is not documented.
/github/workspace/src/controls/estimator.hpp:254: warning: Member icm_imu (variable) of struct GimbalAndChassisEstimator is not documented.
/github/workspace/src/controls/estimator.hpp:256: warning: Member chassis_1 (variable) of struct GimbalAndChassisEstimator is not documented.
/github/workspace/src/controls/estimator.hpp:257: warning: Member chassis_2 (variable) of struct GimbalAndChassisEstimator is not documented.
/github/workspace/src/controls/estimator.hpp:258: warning: Member chassis_3 (variable) of struct GimbalAndChassisEstimator is not documented.
/github/workspace/src/controls/estimator.hpp:259: warning: Member chassis_4 (variable) of struct GimbalAndChassisEstimator is not documented.
/github/workspace/src/controls/estimator.hpp:265: warning: argument 'config_data' of command @param is not found in the argument list of GimbalAndChassisEstimator::GimbalAndChassisEstimator(NewConfig::Estimator, SensorManager &sensor_manager, CANManager &can)
/github/workspace/src/controls/reference_governer.hpp:14: warning: Member reference_state (variable) of class Governor is not documented.
/github/workspace/src/controls/reference_governer.hpp:43: warning: return type of member Governor::set_acceleration_reference is not documented
/github/workspace/src/controls/reference_governer.hpp:49: warning: argument 'governor_type' of command @param is not found in the argument list of Governor::step_reference(const RobotState &ungoverned_reference_map)
/github/workspace/src/controls/reference_governer.hpp:51: warning: The following parameter of Governor::step_reference(const RobotState &ungoverned_reference_map) is not documented:
parameter 'ungoverned_reference_map'
/github/workspace/src/sensors/ICM20649.hpp:18: warning: unable to resolve reference to 'init(CommunicationProtocol)' for \ref command
/github/workspace/src/sensors/ICM20649.hpp:19: warning: parameters of member ICM20649::ICM20649 are not (all) documented
/github/workspace/src/sensors/ICM20649.hpp:25: warning: @copybrief or @copydoc target 'IMUSensor::read()' not found
/github/workspace/src/sensors/ICM20649.hpp:33: warning: Member config (variable) of class ICM20649 is not documented.
/github/workspace/src/sensors/ICM20649.hpp:25: warning: @copybrief or @copydoc target 'IMUSensor::read()' not found
/github/workspace/src/sensors/ICM20649.hpp:25: warning: @copydetails or @copydoc target 'IMUSensor::read()' not found
/github/workspace/src/sensors/ICM20649.hpp:26: warning: return type of member ICM20649::read is not documented
/github/workspace/src/sensors/LSM6DSOX.hpp:13: warning: parameters of member LSM6DSOX::LSM6DSOX are not (all) documented
/github/workspace/src/sensors/LSM6DSOX.hpp:22: warning: Member config (variable) of class LSM6DSOX is not documented.
/github/workspace/src/sensors/can/motor.hpp:31: warning: argument 'controller_type' of command @param is not found in the argument list of Motor::Motor(NewConfig::Motor motor_config)
/github/workspace/src/sensors/can/motor.hpp:31: warning: argument 'gid' of command @param is not found in the argument list of Motor::Motor(NewConfig::Motor motor_config)
/github/workspace/src/sensors/can/motor.hpp:31: warning: argument 'id' of command @param is not found in the argument list of Motor::Motor(NewConfig::Motor motor_config)
/github/workspace/src/sensors/can/motor.hpp:31: warning: argument 'bus' of command @param is not found in the argument list of Motor::Motor(NewConfig::Motor motor_config)
/github/workspace/src/sensors/can/motor.hpp:31: warning: argument 'motor_type' of command @param is not found in the argument list of Motor::Motor(NewConfig::Motor motor_config)
/github/workspace/src/sensors/can/motor.hpp:37: warning: The following parameter of Motor::Motor(NewConfig::Motor motor_config) is not documented:
parameter 'motor_config'
/github/workspace/src/comms/data/motor_state_data.hpp:4: warning: Member torque (variable) of struct MotorStateData is not documented.
/github/workspace/src/comms/data/motor_state_data.hpp:5: warning: Member speed (variable) of struct MotorStateData is not documented.
/github/workspace/src/comms/data/motor_state_data.hpp:6: warning: Member position (variable) of struct MotorStateData is not documented.
/github/workspace/src/comms/data/motor_state_data.hpp:7: warning: Member temperature (variable) of struct MotorStateData is not documented.
/github/workspace/src/comms/data/motor_state_data.hpp:9: warning: Member motor_name (variable) of struct MotorStateData is not documented.
/github/workspace/src/filters/pid_filter.hpp:35: warning: argument 'wrap' of command @param is not found in the argument list of PIDFilter::filter(float dt, bool bound)
/github/workspace/src/controls/controller.hpp:208: warning: Member step(RobotStateMap reference_map, RobotStateMap estimate_map, float outputs[CAN_MAX_MOTORS]) (function) of struct PitchController is not documented.
/github/workspace/src/controls/controller.hpp:26: warning: parameters of member Controller::Controller are not (all) documented
/github/workspace/src/controls/controller.hpp:38: warning: Member config() const (function) of struct Controller is not documented.
/github/workspace/src/controls/controller.hpp:188: warning: Member full_state_position_controller (variable) of struct PitchController is not documented.
/github/workspace/src/controls/controller.hpp:189: warning: Member full_state_velocity_controller (variable) of struct PitchController is not documented.
/github/workspace/src/sensors/RefSystem.hpp:94: warning: documented empty return type of RefSystem::send_to_comms
/github/workspace/src/sensors/rev_encoder.hpp:40: warning: Member get_data_for_comms() (function) of class RevEncoder is not documented.
/github/workspace/src/sensors/rev_encoder.hpp:10: warning: Member config (variable) of class RevEncoder is not documented.
/github/workspace/src/sensors/rev_encoder.hpp:20: warning: argument 'encoder_pin' of command @param is not found in the argument list of RevEncoder::RevEncoder(const NewConfig::RevEncoder &config)
/github/workspace/src/sensors/rev_encoder.hpp:22: warning: The following parameter of RevEncoder::RevEncoder(const NewConfig::RevEncoder &config) is not documented:
parameter 'config'
/github/workspace/src/comms/data/rev_encoder_data.hpp:15: warning: Member encoder_name (variable) of struct RevSensorData is not documented.
/github/workspace/src/controls/robot_state_map.hpp:8: warning: Member StateMapError (enumeration) of class RobotStateMap is not documented.
/github/workspace/src/controls/robot_state_map.hpp:12: warning: Member RobotStateMap(const std::vector< NewConfig::State > &_state_configurations) (function) of class RobotStateMap is not documented.
/github/workspace/src/controls/robot_state_map.hpp:14: warning: Member operator[](NewConfig::StateName state_name) (function) of class RobotStateMap is not documented.
/github/workspace/src/controls/robot_state_map.hpp:16: warning: Member set_position(chassis_pos_x) (function) of class RobotStateMap is not documented.
/github/workspace/src/controls/robot_state_map.hpp:18: warning: Member operator[](NewConfig::StateName state_name) const (function) of class RobotStateMap is not documented.
/github/workspace/src/controls/robot_state_map.hpp:20: warning: Member get_state_for_comms(State states[NUM_STATES]) const (function) of class RobotStateMap is not documented.
/github/workspace/src/controls/robot_state_map.hpp:23: warning: Member robot_state (variable) of class RobotStateMap is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:36: warning: parameters of member SensorManager::init are not (all) documented
/github/workspace/src/sensors/sensor_manager.hpp:38: warning: Member configure_sensors(const NewConfig::RobotConfig &config_data) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:40: warning: Member initialize_sensors() (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:45: warning: Member send_to_comms() (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:47: warning: Member get_buff_encoder_by_name(NewConfig::BuffEncoderName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:48: warning: Member get_rev_encoder_by_name(NewConfig::RevEncoderName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:49: warning: Member get_icm_sensor_by_name(NewConfig::ImuName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:50: warning: Member get_lsm_sensor_by_name(NewConfig::ImuName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:51: warning: Member get_lidar_sensor_by_name(NewConfig::D200LidarName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:52: warning: Member get_limit_switch_by_name(NewConfig::LimitSwitchName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:53: warning: Member get_current_sensor_by_name(NewConfig::CurrentSensorName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:54: warning: Member get_tof_sensor_by_name(NewConfig::TOFSensorName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:55: warning: Member get_stereo_cam_trigger_by_name(NewConfig::StereoCameraTriggerName name) (function) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:77: warning: Member buff_encoders (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:78: warning: Member rev_encoders (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:79: warning: Member icm_imus (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:80: warning: Member lsm_imus (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:81: warning: Member d200_lidars (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:82: warning: Member limit_switches (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:83: warning: Member acs712_current_sensors (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:84: warning: Member tof_sensors (variable) of class SensorManager is not documented.
/github/workspace/src/sensors/sensor_manager.hpp:85: warning: Member stereo_cam_triggers (variable) of class SensorManager is not documented.
/github/workspace/src/controls/state.hpp:9: warning: Member operator+(const State &other) const (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:10: warning: Member operator-(const State &other) const (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:11: warning: Member operator=(const State &other) (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:13: warning: Member set_position(float position) (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:14: warning: Member get_position() const (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:16: warning: Member set_velocity(float velocity) (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:17: warning: Member get_velocity() const (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:19: warning: Member set_acceleration(float acceleration) (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:20: warning: Member get_acceleration() const (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:6: warning: Member config() const (variable) of class State is not documented.
/github/workspace/src/controls/state.hpp:30: warning: Member wrap(float value, float min, float max) const (function) of class State is not documented.
/github/workspace/src/controls/state.hpp:23: warning: Member position (variable) of class State is not documented.
/github/workspace/src/controls/state.hpp:24: warning: Member velocity (variable) of class State is not documented.
/github/workspace/src/controls/state.hpp:25: warning: Member acceleration (variable) of class State is not documented.
/github/workspace/src/controls/state.hpp:27: warning: Member config (variable) of class State is not documented.
/github/workspace/src/sensors/StereoCamTrigger.hpp:13: warning: Member config (variable) of class StereoCamTrigger is not documented.
/github/workspace/src/sensors/StereoCamTrigger.hpp:30: warning: argument '_fps' of command @param is not found in the argument list of StereoCamTrigger::StereoCamTrigger(const NewConfig::StereoCamTriggerConfig &config)
/github/workspace/src/sensors/StereoCamTrigger.hpp:32: warning: The following parameter of StereoCamTrigger::StereoCamTrigger(const NewConfig::StereoCamTriggerConfig &config) is not documented:
parameter 'config'
/github/workspace/src/sensors/Transmitter.hpp:233: warning: Member send_to_comms() (function) of class Transmitter is not documented.
/github/workspace/src/controls/controller.hpp:88: warning: Member step(RobotStateMap reference_map, RobotStateMap estimate_map, float outputs[CAN_MAX_MOTORS]) (function) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:26: warning: parameters of member Controller::Controller are not (all) documented
/github/workspace/src/controls/controller.hpp:38: warning: Member config() const (function) of struct Controller is not documented.
/github/workspace/src/controls/controller.hpp:45: warning: Member xy_position_controller (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:46: warning: Member xy_velocity_controller (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:47: warning: Member chassis_angle_controller (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:48: warning: Member chassis_angular_velocity_controller (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:49: warning: Member low_level_velocity_controller (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:50: warning: Member power_buffer_controller (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:65: warning: Member chassis_motor_1 (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:66: warning: Member chassis_motor_2 (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:67: warning: Member chassis_motor_3 (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:68: warning: Member chassis_motor_4 (variable) of struct XDrivePositionController is not documented.
/github/workspace/src/controls/controller.hpp:138: warning: Member step(RobotStateMap reference_map, RobotStateMap estimate_map, float outputs[CAN_MAX_MOTORS]) (function) of struct XDriveVelocityController is not documented.
/github/workspace/src/controls/controller.hpp:26: warning: parameters of member Controller::Controller are not (all) documented
/github/workspace/src/controls/controller.hpp:38: warning: Member config() const (function) of struct Controller is not documented.
/github/workspace/src/controls/controller.hpp:103: warning: Member xy_velocity_controller (variable) of struct XDriveVelocityController is not documented.
/github/workspace/src/controls/controller.hpp:104: warning: Member chassis_angle_controller (variable) of struct XDriveVelocityController is not documented.
/github/workspace/src/controls/controller.hpp:105: warning: Member chassis_angular_velocity_controller (variable) of struct XDriveVelocityController is not documented.
/github/workspace/src/controls/controller.hpp:106: warning: Member low_level_velocity_controller (variable) of struct XDriveVelocityController is not documented.
/github/workspace/src/controls/controller.hpp:107: warning: Member power_buffer_controller (variable) of struct XDriveVelocityController is not documented.
/github/workspace/src/controls/controller.hpp:175: warning: Member step(RobotStateMap reference_map, RobotStateMap estimate_map, float outputs[CAN_MAX_MOTORS]) (function) of struct YawController is not documented.
/github/workspace/src/controls/controller.hpp:26: warning: parameters of member Controller::Controller are not (all) documented
/github/workspace/src/controls/controller.hpp:38: warning: Member config() const (function) of struct Controller is not documented.
/github/workspace/src/controls/controller.hpp:153: warning: Member full_state_position_controller (variable) of struct YawController is not documented.
/github/workspace/src/controls/controller.hpp:154: warning: Member full_state_velocity_controller (variable) of struct YawController is not documented.
/github/workspace/src/comms/comms_layer.hpp:87: warning: Member configure() (function) of class Comms::CommsLayer is not documented.
/github/workspace/src/comms/data/hive_data.hpp:35: warning: Member config (variable) of struct Comms::HiveData is not documented.
/github/workspace/src/comms/config_data/controller.hpp:40: warning: Member p (variable) of struct NewConfig::Gains is not documented.
/github/workspace/src/comms/config_data/controller.hpp:41: warning: Member i (variable) of struct NewConfig::Gains is not documented.
/github/workspace/src/comms/config_data/controller.hpp:42: warning: Member d (variable) of struct NewConfig::Gains is not documented.
/github/workspace/src/comms/config_data/controller.hpp:43: warning: Member f (variable) of struct NewConfig::Gains is not documented.
/github/workspace/src/comms/config_data/controller.hpp:44: warning: Member power_buffer_threshold (variable) of struct NewConfig::Gains is not documented.
/github/workspace/src/comms/config_data/controller.hpp:45: warning: Member power_buffer_critical_threshold (variable) of struct NewConfig::Gains is not documented.
/github/workspace/src/comms/config_data/controller.hpp:49: warning: Member chassis_x_to_motor_rad (variable) of struct NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/controller.hpp:50: warning: Member chassis_y_to_motor_rad (variable) of struct NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/controller.hpp:51: warning: Member chassis_rad_to_motor_rad (variable) of struct NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/controller.hpp:52: warning: Member motor1_direction (variable) of struct NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/controller.hpp:53: warning: Member motor2_direction (variable) of struct NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/controller.hpp:54: warning: Member ball_to_flywheel_rad (variable) of struct NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/controller.hpp:55: warning: Member feeder_direction (variable) of struct NewConfig::GearRatios is not documented.
/github/workspace/src/comms/config_data/controller.hpp:59: warning: Member gains (variable) of struct NewConfig::SubController is not documented.
/github/workspace/src/comms/config_data/controller.hpp:60: warning: Member sub_controller_type (variable) of struct NewConfig::SubController is not documented.
/github/workspace/src/comms/config_data/controller.hpp:64: warning: Member motor_names[CONTROLLER_MOTORS_SIZE] (variable) of struct NewConfig::Controller is not documented.
/github/workspace/src/comms/config_data/controller.hpp:65: warning: Member sub_controllers[CONTROLLER_SUB_CONTROLLERS_SIZE] (variable) of struct NewConfig::Controller is not documented.
/github/workspace/src/comms/config_data/controller.hpp:66: warning: Member gear_ratios (variable) of struct NewConfig::Controller is not documented.
/github/workspace/src/comms/config_data/controller.hpp:67: warning: Member controller_type (variable) of struct NewConfig::Controller is not documented.
/github/workspace/src/comms/config_data/estimator.hpp:17: warning: Member estimated_states (variable) of struct NewConfig::LowLevelEstimator is not documented.
/github/workspace/src/comms/config_data/estimator.hpp:18: warning: Member estimator_name (variable) of struct NewConfig::LowLevelEstimator is not documented.
/github/workspace/src/comms/config_data/estimator.hpp:26: warning: Member estimated_states (variable) of struct NewConfig::HighLevelEstimator is not documented.
/github/workspace/src/comms/config_data/estimator.hpp:27: warning: Member estimator_name (variable) of struct NewConfig::HighLevelEstimator is not documented.
/github/workspace/src/comms/config_data/motor.hpp:43: warning: Member motor_controller_type (variable) of struct NewConfig::Motor is not documented.
/github/workspace/src/comms/config_data/motor.hpp:44: warning: Member physical_bus (variable) of struct NewConfig::Motor is not documented.
/github/workspace/src/comms/config_data/motor.hpp:45: warning: Member physical_id (variable) of struct NewConfig::Motor is not documented.
/github/workspace/src/comms/config_data/motor.hpp:46: warning: Member motor_type (variable) of struct NewConfig::Motor is not documented.
/github/workspace/src/comms/config_data/motor.hpp:47: warning: Member motor_name (variable) of struct NewConfig::Motor is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:29: warning: Member robot (variable) of struct NewConfig::ConfigStart is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:30: warning: Member num_config_sections (variable) of struct NewConfig::ConfigStart is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:51: warning: Member is_configured() const (function) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:39: warning: Member config_start (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:40: warning: Member controllers (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:41: warning: Member buff_encoders (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:42: warning: Member icm_imus (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:43: warning: Member d200_lidars (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:44: warning: Member realsense_cameras (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:45: warning: Member low_level_estimators (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:46: warning: Member high_level_estimators (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:47: warning: Member states (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:48: warning: Member motors (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/robot_config.hpp:49: warning: Member num_sections_received (variable) of struct NewConfig::RobotConfig is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:46: warning: Member communication_protocol (variable) of struct NewConfig::BuffEncoder is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:47: warning: Member pins (variable) of struct NewConfig::BuffEncoder is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:49: warning: Member encoder_offset (variable) of struct NewConfig::BuffEncoder is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:50: warning: Member feeder_direction (variable) of struct NewConfig::BuffEncoder is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:51: warning: Member feeder_ratio (variable) of struct NewConfig::BuffEncoder is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:52: warning: Member encoder_name (variable) of struct NewConfig::BuffEncoder is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:77: warning: Member communication_protocol (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:78: warning: Member pins (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:80: warning: Member pitch_angle_at_yaw_calibration (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:81: warning: Member yaw_start_angle (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:82: warning: Member pitch_start_angle (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:83: warning: Member roll_start_angle (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:84: warning: Member yaw_axis_vector[3] (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:85: warning: Member pitch_axis_vector[3] (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:86: warning: Member imu_name (variable) of struct NewConfig::IcmImu is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:111: warning: Member x_offset (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:112: warning: Member y_offset (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:113: warning: Member yaw_offset (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:114: warning: Member valid_region_start (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:115: warning: Member valid_region_end (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:116: warning: Member dead_zone_start (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:117: warning: Member dead_zone_end (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:118: warning: Member dead_zone_check_range (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:119: warning: Member lidar_name (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:121: warning: Member communication_protocol (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:122: warning: Member pins (variable) of struct NewConfig::D200Lidar is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:147: warning: Member communication_protocol (variable) of struct NewConfig::StereoCamTrigger is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:148: warning: Member pins (variable) of struct NewConfig::StereoCamTrigger is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:150: warning: Member fps (variable) of struct NewConfig::StereoCamTrigger is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:151: warning: Member trigger_pulse_width (variable) of struct NewConfig::StereoCamTrigger is not documented.
/github/workspace/src/comms/config_data/sensor.hpp:152: warning: Member trigger_name (variable) of struct NewConfig::StereoCamTrigger is not documented.
/github/workspace/src/comms/config_data/state.hpp:23: warning: Member position (variable) of struct NewConfig::ReferenceLimits is not documented.
/github/workspace/src/comms/config_data/state.hpp:24: warning: Member velocity (variable) of struct NewConfig::ReferenceLimits is not documented.
/github/workspace/src/comms/config_data/state.hpp:25: warning: Member acceleration (variable) of struct NewConfig::ReferenceLimits is not documented.
/github/workspace/src/comms/config_data/state.hpp:29: warning: Member min (variable) of struct NewConfig::ReferenceLimit is not documented.
/github/workspace/src/comms/config_data/state.hpp:30: warning: Member max (variable) of struct NewConfig::ReferenceLimit is not documented.
/github/workspace/src/comms/config_data/state.hpp:34: warning: Member reference_limits (variable) of struct NewConfig::State is not documented.
/github/workspace/src/comms/config_data/state.hpp:35: warning: Member governor_type (variable) of struct NewConfig::State is not documented.
/github/workspace/src/comms/config_data/state.hpp:36: warning: Member name (variable) of struct NewConfig::State is not documented.
/github/workspace/src/comms/config_data/state.hpp:37: warning: Member is_wrapping (variable) of struct NewConfig::State is not documented. |
Contributor
Pandabear1125
left a comment
Pandabear1125
left a comment
There was a problem hiding this comment.
Amazing work! Great use of C++, almost looks like rust haha. Mainly just nits/bps, primarily yall not initializing variables. Good stuff!
src/utils/safety.hpp
Outdated
| } | ||
|
|
||
| template<typename... Args> | ||
| [[noreturn]] inline void safety_procedure(const char* message, Args... args) { |
Contributor
There was a problem hiding this comment.
flag: be careful about [[noreturn]], assert may or may not return based on your compiler flags. I would suggest while(1)'ing after the assert.
src/utils/safety.hpp
Outdated
| } | ||
| char buffer[256]; | ||
| snprintf(buffer, sizeof(buffer), message, args...); | ||
| assert(false && buffer); |
Contributor
There was a problem hiding this comment.
Q: Are you sure this works? usually the assert doesnt actually know what buffer is, it will likely just print out "false && buffer" litterally.
| FullStateVelocityController, | ||
| }; | ||
|
|
||
| struct Gains { |
Contributor
There was a problem hiding this comment.
bp: default initialize this
| float power_buffer_critical_threshold; | ||
| }; | ||
|
|
||
| struct GearRatios { |
Contributor
There was a problem hiding this comment.
bp: default initialize this
| #include "utils/timing.hpp" | ||
| #include "controls/robot_state_map.hpp" | ||
|
|
||
| #ifndef STATE_H |
Contributor
There was a problem hiding this comment.
nit/bp: yall are inconsistent with either using header guards or pragma once. I would recommend sticking with pragma once
| #include <vector> | ||
| #include <Arduino.h> | ||
|
|
||
| // Forward declaration |
Contributor
There was a problem hiding this comment.
Q: you need to forward declare this? Does Sendable also include the map or something?
src/sensors/d200.cpp
Outdated
| port(grab_hw_serial_port(config.hardware_serial_port)) | ||
| {} | ||
|
|
||
| HardwareSerial& D200LD14P::grab_hw_serial_port(Cfg::HardwareSerialPort port) { |
Contributor
There was a problem hiding this comment.
this whole config based serial port is pretty sweet
Contributor
There was a problem hiding this comment.
it would be nice to see main get cleaned up a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IN PROG: firmware refactor to support new config and also a cleanup a good amount of the originally written state, controls, estimator, and sensor code.