Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give basler a custom allocator for camera frames.
The C++ API defines an abstract class BufferFactory with methods allocate and free which you can extend to tell basler how to allocate frames
The bindings extend the interface with a "placeholder" class that is constructed with basically a lambda (rust closure) that contains the allocation logic. the placeholder class does not free, so basically C++ does not "own" the memory. The rust provider owns the memory. The closure takes a requested size and hands out basically a raw pointer to the memory you want it to use (as a uintptr_t = usize in rust). Safety is questionable but at least the functionality exists if we end up needing it.
functions to create and attach the buffer factory implemented also.