data: Trim newlines from product_name#232
Merged
vnepogodin merged 1 commit intomasterfrom Mar 24, 2026
Merged
Conversation
1Naim
force-pushed
the
fix/trim-product-name
branch
from
a497320 to
b959f13
Compare
fs::read_to_string(path) returns `product_name\n`. This breaks pattern matching with string anchors fail as the pattern fails to match against the newline. Trim newlines from product_name so that matching patterns with string anchors work correctly. Fixes: 7c30436 ("👷 support product name pattern match") Signed-off-by: Eric Naim <dnaim@cachyos.org>
1Naim
force-pushed
the
fix/trim-product-name
branch
from
b959f13 to
f794748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs::read_to_string(path) returns
product_name\n. This breaks pattern matching with string anchors fail as the pattern fails to match against the newline. Trim newlines from product_name so that matching patterns with string anchors work correctly.