feat: use skeleton during table load - #117
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the home route’s query preloading behavior so the package search table can render a skeleton while data loads, instead of blocking rendering until the query resolves.
Changes:
- Switched the
/route loader fromensureQueryDatato a non-blockingprefetchQuerycall. - Rendered
PackageSearchSkeletonwhile the search query is pending and no data is available. - Tweaked skeleton spacing classes for closer visual alignment with the loaded table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/routes/index.tsx |
Makes route loader start the query without blocking route render. |
src/components/PackageSearch.tsx |
Adds skeleton rendering during pending state. |
src/components/PackageSearchSkeleton.tsx |
Minor spacing tweaks for the skeleton layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
azdanov
force-pushed
the
add-table-skeleton
branch
from
April 25, 2026 18:14
2839566 to
f1f7bb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used previous implementation.
Another option is to use TanStack/table#2386 approach inside the table component and pagination. But that requires more work.