fix(importer): handle duplicate members in object groups#4384
Open
Y4nnikH wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the importer’s group-member flattening and membership update logic to better handle duplicate members in object groups, primarily by deduplicating “flat” members and preventing duplicate group membership inserts.
Changes:
- Change
GroupFlatsMapper.get_*_flats()APIs to returnset[...](deduplicated) instead oflist[...]. - Update object/rule import paths to accommodate set-based flats (including deterministic iteration in one path).
- Adjust unit tests to reflect set semantics and order-insensitive assertions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| roles/importer/files/importer/test/test_fwconfig_import_object.py | Updates tests to use sets for flats and to avoid ordering assumptions in some assertions. |
| roles/importer/files/importer/services/group_flats_mapper.py | Returns set from get_*_flats() to naturally deduplicate flattened members. |
| roles/importer/files/importer/model_controllers/fwconfig_import_rule.py | Converts set-based flats back to lists for downstream rule-ref handling. |
| roles/importer/files/importer/model_controllers/fwconfig_import_object.py | Uses set-based flats, enforces deterministic iteration for flat members, and deduplicates direct group-member inserts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.