Skip to content

refactor: Service Provider removed#4401

Open
ErikPre wants to merge 94 commits into
CactuseSecurity:developfrom
weichwaren-schmiede:refactor/service-provider-elim
Open

refactor: Service Provider removed#4401
ErikPre wants to merge 94 commits into
CactuseSecurity:developfrom
weichwaren-schmiede:refactor/service-provider-elim

Conversation

@ErikPre

@ErikPre ErikPre commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

Removed the service provider and their services

Now there are

  • Mangement State
  • Import State
  • Global State

which have their logically bound lifecycle

Additionally rework of config with all config-parameters in global_state config in one place and configurable in the config file

fwo_api moved to global state but is refreshing the jwt for every import in the loop without recreating the whole fwo_api objects again

@ErikPre ErikPre added the optimization Optimize an existing feature label Mar 18, 2026
@ErikPre ErikPre force-pushed the refactor/service-provider-elim branch from 01537fe to a13b2b3 Compare April 17, 2026 11:07
@gitguardian

gitguardian Bot commented May 4, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
30437335 Triggered Generic Password 815c9cc roles/middleware/files/FWO.Middleware.Server/LdapBasic.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@ErikPre ErikPre force-pushed the refactor/service-provider-elim branch from cd4c08d to 0002252 Compare May 26, 2026 12:41
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimization Optimize an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants