Skip to content

first throw integration/smoke test for ambient role #4781

Open
tpurschke wants to merge 14 commits into
CactuseSecurity:developfrom
tpurschke:test/ambient-role-route-coverage
Open

first throw integration/smoke test for ambient role #4781
tpurschke wants to merge 14 commits into
CactuseSecurity:developfrom
tpurschke:test/ambient-role-route-coverage

Conversation

@tpurschke

@tpurschke tpurschke commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This smoke test was tested against #4780 showing an error without this PR and a clean run with the PR applied.

@Laennart can you have a look at this and see

  • if this kind of integration test is a useful way to go
  • how to best integrate this into the current testing framework (especially regarding requirements.txt and integration into our CI/CD pipeline

@abarz722 FYI

@tpurschke tpurschke changed the title first throw integration tests for ambient role first throw integration/smoke test for ambient role Jun 17, 2026
@tpurschke tpurschke requested a review from Laennart June 18, 2026 07:33
@tpurschke tpurschke marked this pull request as ready for review June 18, 2026 07:35
@tpurschke tpurschke self-assigned this Jun 18, 2026

@Laennart Laennart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @tpurschke!

The structure is easily understandable and the use of pytest fixtures and functionalities is spot-on. The alternative would be to write these tests with Playwright .NET but I think that depends on what language the team is more comfortable with.
Having the tests integrated into the ansible playbook also makes sense since it's directly integrated into the installation process in the CI/CD process and failures will be caught by the pipeline 🙌🏻

@sonarqubecloud

Copy link
Copy Markdown

@SolidProgramming

Copy link
Copy Markdown
Contributor

[...] * if this kind of integration test is a useful way to go

  • how to best integrate this into the current testing framework (especially regarding requirements.txt and integration into our CI/CD pipeline [...]

@tpurschke We could add Playwright nuget package to the test's project instead of python. that would be easiest in my eyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants