Skip to content

Reduce duplicated shared business logic#776

Open
dykdee wants to merge 1 commit into
Calebux:mainfrom
dykdee:fix/602-shared-business-logic
Open

Reduce duplicated shared business logic#776
dykdee wants to merge 1 commit into
Calebux:mainfrom
dykdee:fix/602-shared-business-logic

Conversation

@dykdee
Copy link
Copy Markdown

@dykdee dykdee commented May 30, 2026

Closes #602

Summary:

  • moved repeated subscription spend math into @syncro/shared
  • moved shared URL/email/masking helpers into @syncro/shared
  • rewired client and backend callers to use shared helpers
  • added tests and docs for shared business logic

Tests:

  • npm run lint:deps -w client
  • npm run typecheck -w shared
  • npm run build -w shared
  • npm test -w backend -- shared-business-logic.test.ts
  • npm test -w backend -- telegram-command-service.test.ts
  • npm test -w backend -- validation.test.ts
  • npm test -w client -- lib/tests/validation.test.ts

@dykdee dykdee requested a review from Calebux as a code owner May 30, 2026 00:26
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 30, 2026

@dykdee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] Reduce duplicate business logic between client/lib and backend/src

1 participant