Skip to content

fix(theme): Aurora gateway detail grid — exactly 3 columns (1/3 each) #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CallMeTechie merged 1 commit into from
Jun 22, 2026
Merged

fix(theme): Aurora gateway detail grid — exactly 3 columns (1/3 each) #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions public/css/aurora.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,8 +579,10 @@ input[type=date]:focus, select:focus {
.gw-relnotes{font-size:12px;color:var(--muted);text-decoration:underline;text-underline-offset:2px;opacity:.8}
.gw-relnotes:hover{opacity:1;color:var(--text)}

/* Issue 11: Gateway detail — 3-column (1/3 each) sub-card grid */
.gw-detail-grid{display:grid;grid-template-columns:repeat(auto-fit,minmax(280px,1fr));gap:14px}
/* Issue 11: Gateway detail — exactly 3 columns (1/3 each), max 3 side by side; collapse on narrow */
.gw-detail-grid{display:grid;grid-template-columns:repeat(3,minmax(0,1fr));gap:14px}
@media(max-width:1100px){.gw-detail-grid{grid-template-columns:repeat(2,minmax(0,1fr))}}
@media(max-width:760px){.gw-detail-grid{grid-template-columns:1fr}}
.gw-detail-grid .gw.full{grid-column:1/-1}
/* Fix 3: "Discovered devices" + "Scan targets" at 1/2 width each in their own row */
.gw-half-row{display:grid;grid-template-columns:1fr 1fr;gap:14px;grid-column:1/-1}
Expand Down
4 changes: 2 additions & 2 deletions tests/aurora_theme.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,11 +1456,11 @@ describe('aurora theme — gateways UX fixes (Issues 8/9/10/11)', () => {
assert.match(js, /grid2\.appendChild\(auroraVersionsCard\(g\)\)/, 'auroraRenderDetail() calls auroraVersionsCard(g)');
});

it('Issue 11: auroraRenderDetail uses gw-detail-grid and aurora.css has responsive column rule', () => {
it('Issue 11: auroraRenderDetail uses gw-detail-grid with exactly 3 columns (1/3 each)', () => {
const js = fs.readFileSync(path.join(__dirname, '..', 'public', 'js', 'gateways.js'), 'utf8');
const css = fs.readFileSync(path.join(__dirname, '..', 'public', 'css', 'aurora.css'), 'utf8');
assert.match(js, /el\('div',\s*'gw-detail-grid'\)/, 'auroraRenderDetail() uses gw-detail-grid class');
assert.match(css, /\.gw-detail-grid\s*\{[^}]*repeat\(auto-fit,minmax\(280px,1fr\)\)/, 'gw-detail-grid uses responsive auto-fit column layout');
assert.match(css, /\.gw-detail-grid\s*\{[^}]*repeat\(3,minmax\(0,1fr\)\)/, 'gw-detail-grid uses exactly 3 columns (1/3 each)');
});
});

Expand Down
Loading