fix(theme): Aurora parity — edit-modal tabs, routes buttons, GC contract, rdp-session - #167
Merged
Merged
Conversation
…act, rdp-session
Aurora was missing several things ported from default/never lifted to the pro
superset. This restores them:
- Route-edit modal tabs never switched (and even 'general' was blank): aurora.css
forced .edit-route-panel{display:none} and showed via a .active class, but the
shared JS toggles panels by inline style.display (active = display:''→stylesheet).
So every panel fell back to none. Fixed to not force display:none (keeps fade).
- routes/ page was missing the 'Create service' (#btn-add-service) and 'Set up
printer' (#open-printer-preset) buttons + the entire printer-preset wizard modal
markup. Added all three (printer button auto-shows when gateway TCP routing is
licensed, same as pro).
- ROOT CAUSE for the dead printer wizard: aurora/layout.njk's window.GC block was
copied from default and never updated to the pro superset — it injected only 1 of
6 license features (missing gateway_tcp_routing/scan_egress/l4_routes/http_routes/
browser_sessions) and was missing 33 GC.t keys (all printer_preset.*, common.close/
loading, rdp.badge.browser). Replaced with pro's full window.GC block.
- aurora/pages/rdp-session.njk did not exist → opening a browser RDP session as an
Aurora user 500'd (TemplateNotFound). Added it (pro body + aurora head: pro.css +
aurora.css, data-theme + no-FOUC mode script, aurora fonts).
Aurora-only. Verified with headless-chromium: tabs switch, service+printer modals
open, rdp-session renders 200, aurora_theme.test 144/0.
…de selector - logs/ page dropped the #activity-pagination and #access-pagination containers that logs.js fills → activity/access logs couldn't be paged. Restored both. - rdp/ edit form was missing the #rdp-ssh-auth-mode segment (Password vs Private key) that rdp.js shows for SSH routes (#rdp-ssh-auth-seg + .rdp-auth-opt[data- auth-mode]). Restored, styled with aurora's toggle-group/toggle-btn. (The pro #rdp-confirm-* modal was NOT ported — it is dead markup in pro too; rdp.js confirms via native confirm() with GC.t keys, now present after the layout fix.) Aurora-only. aurora_theme.test 144/0; rdp + logs render clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aurora hatte mehrere Dinge übersehen, die vom Default-Theme kopiert, aber nie auf den Pro-Superset gehoben wurden. Diese Runde behebt die von dir genannten Punkte + den gemeinsamen Root-Cause.
Behoben
.edit-route-panel{display:none}und zeigte per.active-Klasse — der geteilte JS-Handler schaltet Panels aber per Inline-style.display(aktiv =display:''→ Stylesheet-Wert = none). Fix: keindisplay:none-Zwang mehr (Fade bleibt).#btn-add-service) + „Drucker einrichten' (#open-printer-preset) + das komplette Printer-Preset-Wizard-Modal ergänzt.aurora/layout.njkwindow.GCwar von default kopiert — nur 1 von 6 Lizenz-Features (es fehltengateway_tcp_routing/scan_egress/l4_routes/http_routes/browser_sessions) und 33GC.t-Keys (alleprinter_preset.*,common.close/loading,rdp.badge.browser). Durch Pros vollständigen Block ersetzt.aurora/pages/rdp-session.njkfehlte komplett → Öffnen einer Browser-RDP-Sitzung als Aurora-Nutzer warf 500 (TemplateNotFound). Ergänzt (Pro-Body + Aurora-Head).Verifikation (headless-chromium)
Tabs schalten alle 6 · Service- + Printer-Modal öffnen (Printer-Body gefüllt) · rdp-session rendert 200 ·
aurora_theme.test.js144/0 · keine JS-Fehler.Noch offen (separater Folge-PR, im Audit gefunden)
rdp
ssh-auth-mode+ Confirm-Modal, logs-Pagination, gateway-poolspools-table. Dashboard/peers/dns-Stats sind als KPIs/Donuts bewusst redesignt.